Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential version conflicts with system libraries #18

Closed
KrisThielemans opened this issue May 4, 2017 · 8 comments
Closed

potential version conflicts with system libraries #18

KrisThielemans opened this issue May 4, 2017 · 8 comments
Assignees
Milestone

Comments

@KrisThielemans
Copy link
Member

Currently, some packages (such as GTest) can have conflicts if a system library is found, but we want to use our own.

email sent to cmake@cmake.org

@KrisThielemans KrisThielemans modified the milestones: v0.9, v1.0 May 4, 2017
@KrisThielemans
Copy link
Member Author

KrisThielemans commented May 5, 2017

Fixed GTest with 32e404d. Rest might be ok so shifting milestone.

@KrisThielemans
Copy link
Member Author

GTEST_ROOT is now correct but FindGTest.cmake is still finding an existing library first unfortunately, leading to linking errors if that version is older than the one we built.

@KrisThielemans KrisThielemans modified the milestones: v0.9, v1.0 May 5, 2017
@KrisThielemans
Copy link
Member Author

Robert Maynard at kitware.com suggests

Have you tried using CMAKE_PREFIX_PATH instead of CMAKE_INSTALL_PREFIX?

@paskino, could you give that a try? e.g. remove the BOOST_ROOT variable pass-through, and see if it still picks up our files as opposed to the system ones. please also test for GTest (copy libgtest.a to /usr/local/lib. it should NOT be found, but will be at present)

@paskino paskino self-assigned this May 11, 2017
@paskino
Copy link
Contributor

paskino commented May 15, 2017

I've tested right now.

  1. Installed system boost
  2. removed -DBOOST_ROOT

it found the system boost. So the BOOST_ROOT variable seems necessary.

@KrisThielemans
Copy link
Member Author

did you add CMAKE_PREFIX_PATH in the External_SIRF.cmake ? (or whatever project you tried)

@paskino
Copy link
Contributor

paskino commented May 16, 2017

I tried it on Gadgetron. The CMAKE_PREFIX_PATH was already there.

@KrisThielemans
Copy link
Member Author

ah well. indeed, this was already there when we tried with David. I'll reply to the CMake list.

@KrisThielemans
Copy link
Member Author

Closing this as probably resolved. However, see also related #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants