Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in preprocessing_acquisition_data: empty result with ISMRMRD 1.4.2.1 #948

Closed
KrisThielemans opened this issue Jun 14, 2021 · 4 comments
Assignees
Milestone

Comments

@KrisThielemans
Copy link
Member

When my SIRF was compiled with ISMRMR 1.4.2, running SIRF-Exercises/Introductory/acquisition_model_mr_pet_ct.ipynb gave

mr_acq = mr.AcquisitionData(os.path.join(examples_data_path('MR'),'grappa2_1rep.h5'))
preprocessed_data = mr.preprocess_acquisition_data(mr_acq)

csm = mr.CoilSensitivityData()
csm.smoothness = 50
csm.calculate(preprocessed_data)

This gives me an error

error: ??? "'Please pass a non-empty container.

Trying to investigate:

> preprocessed_data.dimensions()

array([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], dtype=int32)

> xxx=preprocessed_data.as_array()

---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-11-e6795c6316a5> in <module>
----> 1 xxx=preprocessed_data.as_array()

~/devel/install/python/sirf/Gadgetron.py in as_array(self, acq)
    984         assert self.handle is not None
    985         if acq is None:
--> 986             ny, nc, ns = self.dimensions()
    987             z = numpy.ndarray((ny, nc, ns), dtype = numpy.complex64)
    988             acq = -1

ValueError: too many values to unpack (expected 3)

This was on my own VM with SIRF/master. Something that has changed in ISMRMRD presumably.

Let's postpone this to later of course.

@evgueni-ovtchinnikov
Copy link
Contributor

@KrisThielemans

When my SIRF was compiled with ISMRMR 1.4.2, running SIRF-Exercises/Introductory/acquisition_model_mr_pet_ct.ipynb gave

1.4.2 (as above) or 1.4.2.1 (as in the issue title)?

I could not reproduce this error with 1.4.2.1, only the error due to the sorting issue (c/o Johannes)

@KrisThielemans
Copy link
Member Author

hmmm. I think 1.4.2.1 but as I've deleted it, I don't know.

By the way, I did recompile gadgetron with that ismrmrd library.

anyway, let's leave this one for later once we do the transition.

@KrisThielemans KrisThielemans modified the milestones: v3.4, v3.3 Apr 28, 2022
@KrisThielemans
Copy link
Member Author

@ckolbPTB to try

@ckolbPTB
Copy link
Contributor

In the current VM version 3.2 this problem does not occur anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants