You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
SEP23 is still a Draft. We plan to (at least initally) use the M-strkey representation to explore the use of Muxed Accounts. Later on, we me consider it stable and enable it by default.
As such, it's critical to make M-strkeys an opt-in feature (e.g. only usable by the user through am explicitly enabled flag or other mechanisms).
In particular, no user should be enabling M-addresss unknowingly, either for new or existing code (e.g. through an SDK update).
Recent SEP23 representation change
If you were already familiar with SEP23, it's worth noting that the encoding ordering changed recently at stellar/stellar-protocol#895
The SEP 23 specification already contains that modification.
Reference implementation
You can use the Go SDK implementation as a reference: stellar/go#3527
In the Go SDK we have one entry point into generating transaction envelopes, NewTransaction() . We added a configuration parameter to NewTransaction() which toggles support for muxed accounts. If NewTransaction() is configured with muxed account support then it will interpret "M..." address strings as muxed accounts at the xdr level. However, if NewTransaction() is configured to disable muxed accounts, whenever an "M..." address is provided we will extract the underlying "G..." address from and use that at the XDR level.
We followed a similar approach for the other entry points of the SDK (namely TransactionFromXDR() and NewFeeBumpTransaction()).
The text was updated successfully, but these errors were encountered:
TL;DR
Add opt-in support for SEP 23. SEP23 adds a strkey representation (M-strkeys) for MuxedAccounts.
For example, given the MuxedAccount
MAQAA5L65LSYH7CQ3VTJ7F3HHLGCL3DSLAR2Y47263D56MNNGHSQSAAAAAAAAAAE2LP26
, you might get the following fields:It should be implemented as an opt-in feature
SEP23 is still a Draft. We plan to (at least initally) use the M-strkey representation to explore the use of Muxed Accounts. Later on, we me consider it stable and enable it by default.
As such, it's critical to make M-strkeys an opt-in feature (e.g. only usable by the user through am explicitly enabled flag or other mechanisms).
In particular, no user should be enabling M-addresss unknowingly, either for new or existing code (e.g. through an SDK update).
Recent SEP23 representation change
If you were already familiar with SEP23, it's worth noting that the encoding ordering changed recently at stellar/stellar-protocol#895
The SEP 23 specification already contains that modification.
Reference implementation
You can use the Go SDK implementation as a reference: stellar/go#3527
In the Go SDK we have one entry point into generating transaction envelopes,
NewTransaction()
. We added a configuration parameter toNewTransaction()
which toggles support for muxed accounts. IfNewTransaction()
is configured with muxed account support then it will interpret"M..."
address strings as muxed accounts at the xdr level. However, ifNewTransaction()
is configured to disable muxed accounts, whenever an"M..."
address is provided we will extract the underlying"G..."
address from and use that at the XDR level.We followed a similar approach for the other entry points of the SDK (namely
TransactionFromXDR()
andNewFeeBumpTransaction()
).The text was updated successfully, but these errors were encountered: