Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid include of pure python wheels in packages #4589

Closed
hgy59 opened this issue Apr 28, 2021 · 1 comment
Closed

avoid include of pure python wheels in packages #4589

hgy59 opened this issue Apr 28, 2021 · 1 comment

Comments

@hgy59
Copy link
Contributor

hgy59 commented Apr 28, 2021

Discussion started in #4475 (comment)

To reduce the spk package size, only cross compiled wheels should be included in the package (wheelhouse).
Pure python packages should always be downloaded at installation time.

For an unknown reason all *.whl files are renamed to *-none-any.whl" for the package at post_wheel_target in spksrc.wheel.mk:

post_wheel_target: $(WHEEL_TARGET)
  @if [ -d "$(WORK_DIR)/wheelhouse" ] ; then \
    mkdir -p $(STAGING_INSTALL_PREFIX)/share/wheelhouse ; \
      cd $(WORK_DIR)/wheelhouse && \
        for w in *.whl; do \
        cp -f $$w $(STAGING_INSTALL_PREFIX)/share/wheelhouse/`echo $$w | cut -d"-" -f -3`-none-any.whl; \
      done ; \
  fi

An initial solution would copy only wheels that are not "*-none-any.whl" in post_wheel_target (and ommit the renaming).

The real solution should avoid to (download and) cross compile pure python packages at all and not only skip those in post_wheel_target.
It might be a challenge to recognize pure python packages without download.

Side effect:
The installer code of all packages that install wheels must be adjusted to include download form pypi (ommit --no-index) and must use the requirements file and not *.whl alone.

@hgy59
Copy link
Contributor Author

hgy59 commented Dec 17, 2022

implemented with #4986 et al.

@hgy59 hgy59 closed this as completed Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant