add tests to global params

Author: leomassazza

protocol/synthetix/test/integration/modules/core/VaultModuleDelegationTiming.test.ts

@@ -9,7 +9,7 @@ import { bn, bootstrapWithStakedPool } from '../../bootstrap';
 import { delegateCollateral, declareDelegateIntent } from '../../../common';
 import { fastForwardTo, getTime } from '@synthetixio/core-utils/utils/hardhat/rpc';
 
-describe('VaultModule Two-step Delegation', function () {
+describe('VaultModule Two-step Delegation timing', function () {
   const {
     signers,
     systems,
@@ -224,6 +224,76 @@ describe('VaultModule Two-step Delegation', function () {
     });
   });
 
+  describe('Delegation Timing failures with global params', async () => {
+    let intentId: BigNumber;
+    let declareDelegateIntentTime: number;
+    before('set global window times', async () => {
+      await systems()
+        .Core.connect(owner)
+        .setConfig(
+          ethers.utils.formatBytes32String('delegateCollateralDelay_min'),
+          ethers.utils.hexZeroPad(bn(120).toHexString(), 32)
+        ); // use 120 as the global min delay
+      await systems()
+        .Core.connect(owner)
+        .setConfig(
+          ethers.utils.formatBytes32String('delegateCollateralWindow_max'),
+          ethers.utils.hexZeroPad(bn(10).toHexString(), 32)
+        ); // use 10 as the global max window
+    });
+
+    before('set market window times', async () => {
+      const previousConfiguration = await MockMarket.getDelegationCollateralConfiguration();
+      await MockMarket.setDelegationCollateralConfiguration(
+        10,
+        200,
+        previousConfiguration[2],
+        previousConfiguration[3]
+      );
+    });
+
+    before('declare intent to delegate', async () => {
+      intentId = await declareDelegateIntent(
+        systems,
+        owner,
+        user1,
+        accountId,
+        poolId,
+        collateralAddress(),
+        depositAmount.mul(2),
+        ethers.utils.parseEther('1')
+      );
+
+      declareDelegateIntentTime = await getTime(provider());
+    });
+
+    after(restore);
+
+    it('fails to execute a delegation if window is not open (too soon)', async () => {
+      await fastForwardTo(declareDelegateIntentTime + 115, provider());
+
+      await assertRevert(
+        systems()
+          .Core.connect(user2)
+          .processIntentToDelegateCollateralByIntents(accountId, [intentId]),
+        `DelegationIntentNotReady`,
+        systems().Core
+      );
+    });
+
+    it('fails to execute a delegation if window is already closed (too late)', async () => {
+      await fastForwardTo(declareDelegateIntentTime + 131, provider());
+
+      await assertRevert(
+        systems()
+          .Core.connect(user2)
+          .processIntentToDelegateCollateralByIntents(accountId, [intentId]),
+        `DelegationIntentExpired`,
+        systems().Core
+      );
+    });
+  });
+
   describe('Force Delete intents (only system owner)', async () => {
     let intentId: BigNumber;
     before('declare intent to delegate', async () => {