Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinc 3D viewer requires that the first column of the amx be labled "Sample" #158

Open
JohnHadish opened this issue Jun 23, 2020 · 4 comments
Assignees
Milestone

Comments

@JohnHadish
Copy link
Collaborator

This is not the case for the rest of KINC.

@spficklin
Copy link
Member

@JohnHadish there is a --sample_col argument to the 3D viewer that lets you set the name of the sample column. But your question makes me realize there isn't good help instructions for the tool. I'll fix it.

@spficklin
Copy link
Member

PR resolves this issue.

@JohnHadish JohnHadish reopened this Jul 6, 2020
@JohnHadish
Copy link
Collaborator Author

Still requires user to set a column name, which is inconsistent with the rest of KINC. I am of the opinion that if the user is able to get to this point without renaming their data/ setting a --sample-column arguement, that they should not be required to do so during the inal step

@spficklin
Copy link
Member

I think KINC itself needs this argument. In the cond-test analytic, KINC looks for a column named 'Sample' in the amx file and if it can't find it, then it defaults to using the first column regardless of what's in it. This is not mentioned in the documentation for the argument and may cause a problem for folks who's amx file doesn't follow either of those expectations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants