Skip to content

Commit 41116e6

Browse files
authored
feat: TUP-700 @tacc/core-components - publish (#464)
* test: move peerDeps to devDeps To avoid error like: ``` npm ERR! code ERESOLVE npm ERR! ERESOLVE unable to resolve dependency tree npm ERR! npm ERR! While resolving: hazmapper@0.0.0 npm ERR! Found: vite@3.2.10 npm ERR! node_modules/vite npm ERR! dev vite@"^3.0.7" from the root project npm ERR! npm ERR! Could not resolve dependency: npm ERR! peer vite@"^5.0.0" from @nx/vite@17.3.2 npm ERR! node_modules/@nx/vite npm ERR! peer @nx/vite@"^17.2.8" from @tacc/core-components@0.0.1 npm ERR! node_modules/@tacc/core-components npm ERR! @tacc/core-components@"file:../../tacc-core-components-0.0.1.tgz" from the root project ``` * fix: match root & core-components vite…css version * fix: move vite…css to devDep * fix: core-components devDeps * fix: react-dropzone not a core-components dep yet * fix: missing @nx/react (thus no css module .d.ts) * conf: remove NPM scripts cuz they do not work The commands via `nx` for core-components DO work! * fix: missing @testing-library/user-event
1 parent df64ce7 commit 41116e6

File tree

4 files changed

+1054
-198
lines changed

4 files changed

+1054
-198
lines changed

libs/core-components/README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@ Set up a new local CMS instance.
5858

5959
The components are [React components](https://react.dev/learn) that should be [written in TypeScript](https://react.dev/learn/typescript#typescript-with-react-components).
6060

61-
| command | task | service |
62-
| --------------- | ------------------ | ----------------------------- |
63-
| `npm test` | execute unit tests | [Vitest](https://vitest.dev/) |
64-
| `npm run build` | build components | [Vite](https://vitejs.dev/) |
61+
| command | task | service |
62+
| ------------------------------ | ------------------ | ----------------------------- |
63+
| `npx nx test core-components` | execute unit tests | [Vitest](https://vitest.dev/) |
64+
| `npx nx build core-components` | build components | [Vite](https://vitejs.dev/) |
6565

6666
## Contributing
6767

libs/core-components/package.json

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,30 +9,30 @@
99
"files": [
1010
"dist"
1111
],
12-
"scripts": {
13-
"start": "nx serve",
14-
"build": "nx build",
15-
"build:storbook": "nx build-storybook",
16-
"test": "nx test",
17-
"prepublishOnly": "npm run build"
18-
},
1912
"homepage": "https://github.com/TACC/tup-ui/libs/core-components",
20-
"peerDependencies": {
21-
"@nx/vite": "^17.2.8",
22-
"@tacc/core-styles": "^2.25.1",
23-
"@testing-library/jest-dom": "^5.17.0",
24-
"@testing-library/react": "^14.0.0",
25-
"@vitejs/plugin-react-swc": "^3.5.0",
13+
"dependencies": {
2614
"formik": "^2.2.9",
2715
"react": "18.2.0",
2816
"react-dom": "18.2.0",
17+
"react-dropzone": "^14.2.3",
2918
"react-resize-detector": "^7.1.2",
3019
"react-router-dom": "6.11.2",
3120
"react-step-wizard": "^5.3.11",
3221
"react-table": "^7.8.0",
3322
"reactstrap": "^9.1.5",
23+
"uuid": "^8.3.2"
24+
},
25+
"devDependencies": {
26+
"@nx/react": "^17.2.8",
27+
"@nx/vite": "^17.2.8",
28+
"@tacc/core-styles": "^2.25.1",
29+
"@testing-library/jest-dom": "^5.17.0",
30+
"@testing-library/react": "^14.0.0",
31+
"@testing-library/user-event": "^14.5.2",
32+
"@vitejs/plugin-react-swc": "^3.5.0",
3433
"uuid": "^8.3.2",
3534
"vite-plugin-dts": "^2.3.0",
35+
"vite-plugin-lib-inject-css": "^2.1.1",
3636
"vite-tsconfig-paths": "^4.2.0"
3737
},
3838
"sideEffects": [
@@ -43,8 +43,5 @@
4343
"@storybook/addon-essentials": "^7.6.19",
4444
"@storybook/core-server": "^7.6.19",
4545
"@storybook/react-vite": "^7.6.19"
46-
},
47-
"devDependencies": {
48-
"vite-plugin-lib-inject-css": "^2.1.1"
4946
}
5047
}

0 commit comments

Comments
 (0)