Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recomendations for update to alta_veesta.ino #1

Open
ghost opened this issue May 23, 2018 · 1 comment
Open

Recomendations for update to alta_veesta.ino #1

ghost opened this issue May 23, 2018 · 1 comment

Comments

@ghost
Copy link

ghost commented May 23, 2018

Attached file is a recomended update to the INO from the May 21st file posted.

  • Added (F to every Seriel.print strings possible.
  • Added a #ifdef DEBUG around the print unkown char code as that is really only needed in debug and not required for normal operations that I can see and just clutters the console.

alta_veesta.zip

@markkimsal
Copy link
Contributor

Thanks for the F() statements, but I won't be able to merge them for a while.

The unknown chars is a borderline error condition. Yeah, they're not useful, but they represent a flaw in the system that I feel should be known whether or not you are debugging. They shouldn't be cluttering up the console too much, but also they are json so a script can easily ignore type=='unknown'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant