Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating blip_buf? #1312

Closed
NWPlayer123 opened this issue Sep 9, 2018 · 3 comments
Closed

Updating blip_buf? #1312

NWPlayer123 opened this issue Sep 9, 2018 · 3 comments
Labels
Meta Relating to code organisation or to things that aren't code

Comments

@NWPlayer123
Copy link

Was poking around earlier, any reason blip_buf(fer) was never updated to the C++ version/replaced/made more versatile? Even using Wayback Machine, the site it comes from only has the C++ version.

@zeromus
Copy link
Contributor

zeromus commented Sep 12, 2018

any reason it needs updating?

@Asnivor
Copy link
Contributor

Asnivor commented Sep 12, 2018

Looking at the changelog (https://github.com/eriser/blip-buffer/blob/master/changes.txt) the standout things between the latest version (0.4.0) and our version (0.1.0) are:

  • Improved sound quality by rewriting library to use 32-bit internal sample
    buffer, higher phase resolution, and a properly windowed filter kernel. Current
    user code should work without changes
  • Implemented workaround for MSVC++ 6 compiler limitations, allowing it to work
    on that compiler again
  • Added several multi-channel buffers that do panning and stereo echo
  • Added sample clamping to Blip_Buffer::read_samples(), allowing higher volume
    with little distortion

There are also some API and value type changes by the looks of it. Although I don't think our wrapper is implementing any of the EQ-related stuff anyways (as far as I recall), nor the BlipSynth/BlipWave generator stuff. So a transition may not be too tricky.

Sounds like it might be a good thing (to be executed by someone who has the first clue about compiling c++ and creating wrappers for unmanaged DLLs).

@zeromus
Copy link
Contributor

zeromus commented Sep 12, 2018

the API is now c++, there is no C, and the APU is considerably different. this isn't worth the trouble unless someone comes up with a compelling reason. they can open another ticket later, unless @NWPlayer123 has a compelling reason, then reply here

@zeromus zeromus closed this as completed Sep 12, 2018
@YoshiRulz YoshiRulz added the Meta Relating to code organisation or to things that aren't code label Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta Relating to code organisation or to things that aren't code
Projects
None yet
Development

No branches or pull requests

4 participants