Make all Forms inherit FormBase instead
#4005
Labels
App: EmuHawk
Relating to EmuHawk frontend
Enhancement
For feature requests or possible improvements
good first issue
GitHub uses this label to recommend Issues
Meta
Relating to code organisation or to things that aren't code
Open to PRs for existing design
We'd love to have this feature, and have a design, but no dev is working on it. PRs welcome.
Comments
YoshiRulz
added
Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This was always intended to become a universal base class. The goal was to have a way to inject anything into every form, if that ever became necessary—but it's since become clear that proper input handling involves passing the focused window's inputs (or a subset thereof) to the root, so this would have multiple benefits.
(TODO put a nicer checklist here—link file and group by subdir)
A7800ControllerSettingsA7800FilterSettingsAddBreakpointDialogAmstradCpcAudioSettingsAmstradCpcCoreEmulationSettingsAmstradCpcNonSyncSettingsArchiveChooserAutofireConfigBSNESControllerSettingsBSNESOptionsBatchRunBizBoxCGBColorChooserFormColecoControllerSettingsColorChooserFormControllerConfigDisplayConfigEditCommentsFormEditSubtitlesFormEmuHawkOptionsExceptionBoxFFmpegDownloaderFormFFmpegWriterFormFileExtensionPreferencesFirmwaresConfigFirmwaresConfigInfoFramesPromptGBLPrefsGBPrefsGenericCoreConfigGifWriterFormGreenzoneSettingsHexColorsFormHexFindHotkeyConfigInputPromptIntvControllerSettingsJmdFormLuaCanvasLuaFunctionsFormLuaRegisteredFunctionsListLuaWinformMessageConfigMobileBmpViewMobileDetailViewMovieHeaderEditorMsgBoxN64ControllersSetupN64MatrixDisplayDialogN64VideoPluginConfigNESGraphicsConfigNESSyncSettingsFormNesControllerSettingsNesVsSettingsOpenAdvancedChooserPSXControllerConfigPSXOptionsPathConfigPathInfoPatternsFormPlatformChooserPlayMovieProfileConfigQuickNesConfigRAIntegrationDownloaderFormRCheevosAchievementFormRCheevosAchievementListFormRCheevosGameInfoFormRCheevosLeaderboardFormRCheevosLeaderboardListFormRCheevosLoginFormRamPokeRecordMovieRewindConfigRomStatusPickerSNESControllerSettingsSNESOptionsSameBoyColorChooserFormScreenshotFormSoundConfigSubtitleMakerSynclessRecordingToolsTAStudioColorSettingsFormTI83PaletteConfigUndoHistoryFormVideoWriterChooserFormWatchEditorZxSpectrumAudioSettingsZxSpectrumCoreEmulationSettingsZxSpectrumJoystickSettingsZxSpectrumNonSyncSettingsThe text was updated successfully, but these errors were encountered: