Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickNES crashed when I tried to switch games (Bizhawk 2.10) #4246

Open
Grandmaster9918 opened this issue Feb 27, 2025 · 5 comments
Open

QuickNES crashed when I tried to switch games (Bizhawk 2.10) #4246

Grandmaster9918 opened this issue Feb 27, 2025 · 5 comments
Labels
App: EmuHawk Relating to EmuHawk frontend Core: QuickNes (Alt.) Nintendo Entertainment System (NES) / Famicom / Famicom Disk System (FDS) core Repro: Affects 2.10

Comments

@Grandmaster9918
Copy link

Grandmaster9918 commented Feb 27, 2025

Summary

Loaded ROM: Akumajou Densetsu Japan
Loaded Core: QuickNES
Open Tools: PPU viewer.

Repro

  1. Paused the game
  2. Opened the PPU viewer
  3. Tried to switch game
  4. Emulator crashed

Output

System.IndexOutOfRangeException: Index was outside the bounds of the array.
   at BizHawk.Client.EmuHawk.NesPPU.HandlePaletteViewMouseMove(Point e) in /_/src/BizHawk.Client.EmuHawk/tools/NES/NESPPU.cs:line 669
   at BizHawk.Client.EmuHawk.NesPPU.Generate(Boolean now) in /_/src/BizHawk.Client.EmuHawk/tools/NES/NESPPU.cs:line 279
   at BizHawk.Emulation.Cores.Consoles.Nintendo.QuickNES.QuickNES.FrameAdvance(IController controller, Boolean render, Boolean rendersound) in /_/src/BizHawk.Emulation.Cores/Consoles/Nintendo/QuickNES/QuickNES.cs:line 352
   at BizHawk.Client.EmuHawk.MainForm.StepRunLoop_Core(Boolean force) in /_/src/BizHawk.Client.EmuHawk/MainForm.cs:line 3063
   at BizHawk.Client.EmuHawk.MainForm.ProgramRunLoop() in /_/src/BizHawk.Client.EmuHawk/MainForm.cs:line 898
   at BizHawk.Client.EmuHawk.Program.SubMain(String[] args) in /_/src/BizHawk.Client.EmuHawk/Program.cs:line 351

Host env.

  • BizHawk 2.10, Windows 11, AMD64.
@Grandmaster9918 Grandmaster9918 changed the title (issue title -- summarise the summary) QuickNES crashed when I tried to switch games (Bizhawk 2.10) Feb 27, 2025
@Morilli
Copy link
Collaborator

Morilli commented Feb 28, 2025

I can't reproduce this. It could depend on the mouse position, the specific frame that was paused on and even which game you tried to switch to.

@YoshiRulz
Copy link
Member

Based on the stacktrace I assume this is because WinForms events are async, so see also #3413.

@YoshiRulz YoshiRulz added App: EmuHawk Relating to EmuHawk frontend Core: QuickNes (Alt.) Nintendo Entertainment System (NES) / Famicom / Famicom Disk System (FDS) core Repro: Affects 2.10 labels Feb 28, 2025
@Grandmaster9918
Copy link
Author

I can't reproduce this. It could depend on the mouse position, the specific frame that was paused on and even which game you tried to switch to.

I tried to switch to a genesis game.

@Morilli
Copy link
Collaborator

Morilli commented Feb 28, 2025

Based on the stacktrace I assume this is because WinForms events are async, so see also #3413.

I doubt it. The stacktrace shows the exception coming from a frame advance call inside of the normal program loop.

I tried to switch to a genesis game.

That's interesting information, however I still can't reproduce this by switching to a genesis game, the ppu viewer just closes before the genesis game is loaded (as would be expected).

@Grandmaster9918
Copy link
Author

maybe it is a one time only bug, but it would be nice to improve stability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App: EmuHawk Relating to EmuHawk frontend Core: QuickNes (Alt.) Nintendo Entertainment System (NES) / Famicom / Famicom Disk System (FDS) core Repro: Affects 2.10
Projects
None yet
Development

No branches or pull requests

3 participants