Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremely inaccurate triangle pitch in VS. Excitebike FDS (not arcade version) #640

Open
riggles1 opened this issue Apr 24, 2023 · 4 comments

Comments

@riggles1
Copy link

riggles1 commented Apr 24, 2023

Start VS. Excitebike.fds and on disk B start the original excite mode, in both the menu and gameplay on the playback of the triangle is at a wrong pitch.

https://cdn.discordapp.com/attachments/611876466187304960/1100168777976533132/Excitebike_FDS_incorrect_pitch.mp3

How it should sound:
https://cdn.discordapp.com/attachments/611876466187304960/1100168856116412576/Excitebike_FDS_correct_pitch.mp3

I hope this issue gets some priority as it's a pretty big one and I love this emulator, what other fds games have the sound emulation affected like this?

@negativeExponent
Copy link
Contributor

negativeExponent commented May 7, 2023

is it really the triangle channel? i know FDS audio mod is missing or incomplete hence some "wierdness" in FDS expansion audio (like zelda's death effect).

Mednafen, using a port of fceux has better (if not accurate) FDS audio emulation, maybe someone can port it or something or use it as reference to fix fceux FDS expansion audio emulation.

@riggles1
Copy link
Author

riggles1 commented May 7, 2023

Not the dedicated triangle channel, but the FDS channel that for this case makes a triangle sound for the bassline.
Porting over that would be amazing as it's the biggest drawback with fceumm+fceux currently, as bad as even just going on Youtube and watching the most viewed FDS VS. Excitebike gameplay will give you videos where the pitch off.

(other niceties for fceux/mm in the future would be audio volume settings for all the channels, and automatic FDS side swapping, hopefully some day, either case, the FDS pitch issue seems pretty urgent)

@vicde
Copy link

vicde commented May 7, 2023

Here the same problem in punes

punesemu/puNES#295

fixed in this comment

punesemu/puNES@f707fe4

@negativeExponent
Copy link
Contributor

ive just blindlt ported mdfn's fds audio code into fceux and indeed sounds are better including Excite Bike. not sure how accurate it is but it sounds better. sadly i cant get it to work when soundquality is set to low.
hope someone would look into is as im not knowledgeable with how internerla hardware works ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants