Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider changing some of our HTTP codes in the API section #72

Closed
csuwildcat opened this issue Dec 12, 2023 · 1 comment
Closed

Consider changing some of our HTTP codes in the API section #72

csuwildcat opened this issue Dec 12, 2023 · 1 comment
Assignees
@decentralgabe
Labels
specification

Comments

@csuwildcat
Copy link
Collaborator

Describe the bug
We use 404s for unimplemented features where we should probably be using 501s (hashing for POW spam prevention), and are using 404s on no results when we should probably return a 200 with an empty response (searching for types, probably should be an empty array).
@csuwildcat csuwildcat added bug Something isn't working specification and removed bug Something isn't working labels Dec 12, 2023
@decentralgabe decentralgabe self-assigned this Dec 19, 2023
@decentralgabe decentralgabe mentioned this issue Dec 19, 2023
Draft
@decentralgabe decentralgabe mentioned this issue Jan 4, 2024
Merged
@decentralgabe
Copy link
Member

fixed by #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@decentralgabe decentralgabe

Labels
specification
Projects
SDK Development
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@csuwildcat @decentralgabe