-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce build times and frontend JS size by removing excess dependencies. #2147
Comments
Looks like this might be adding a lot of deps that we don't need: jsonnext/codemirror-json-schema#125 |
Removing codemirror deps and temporarily showing a blank div brings the build down to 3s and 1.7 MB. |
@gak I just tried this locally on this branch and on
Definitely reduces the size though. I'm ok with pulling this out for now, but we might have to clean up the new version of the form a bit since this might be the most used feature on the console 😂 |
Also, without json-schema validation in the UI it might be really difficult for users to know what fields they need to send on a request. Maybe we need to solve that in another way, but there currently isn't a great way to see what should and should not be there. 🤔 |
I am bringing it back, just with less deps. It will at least save the size of the deploy at least. |
Nice! Sounds great 👍 |
I think this was "fixed" with #2183 |
Ah of course, closing! |
Currently it takes ~10s to build release on a M2, and 16.1 MB to serve in dev.
All FTL builds and most CI rely on this install.
The text was updated successfully, but these errors were encountered: