Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to connect should result into an error with ftl deploy #3142

Open
jvmakine opened this issue Oct 16, 2024 · 0 comments
Open

Failure to connect should result into an error with ftl deploy #3142

jvmakine opened this issue Oct 16, 2024 · 0 comments
Labels
bug Something isn't working next Work that will be be picked up next P1

Comments

@jvmakine
Copy link
Contributor 

> ftl deploy --endpoint=http://localhost:4678/
info:alice:build: Building module
info:alice:build: Module built (1.99s)
info:alice:deploy: Deploying module
◞[alice] 
>

It seems that the deploy is a success, even if there is nothing listening to port 4678.

We should give a clear error that the CLI failed to connect.
@jvmakine jvmakine added the bug Something isn't working label Oct 16, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Oct 16, 2024
@ftl-robot ftl-robot mentioned this issue Oct 16, 2024
Open
@alecthomas alecthomas added P1 next Work that will be be picked up next and removed triage Issue needs triaging labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working next Work that will be be picked up next P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alecthomas @jvmakine