This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

ion.PatchesToDIDDocument has unused param #438

Open

andresuribe87 opened this issue Aug 2, 2023 · 0 comments

Contributor

andresuribe87 commented Aug 2, 2023

The first param is not used on the function

ssi-sdk/did/ion/did.go

Line 112 in 8db407f

    
           func PatchesToDIDDocument(shortFormDID, longFormDID string, patches []Patch) (*did.Document, error) {

We should remove it. Additionally, it should be made clear that it can be long/short form DIDs, as it should be up to the caller to decide.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.