Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Readme links for steps to issue Employment VC leads to 404s #400

Closed
jiyoonie9 opened this issue May 3, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@jiyoonie9
Copy link

Describe the bug
Clicking on any of links in the numbered list under this heading in the readme leads to 404, pointing to a line in a file in https://github.com/TBD54566975/ssi-service/blob/main/blob/main/integration/common.go#L36, but I think that file now lives in https://github.com/TBD54566975/ssi-service/blob/main/integration/common.go

However, even with the correct link, it is unclear to me (as someone new to web5 components) how these lines should help me understand each step to issue Employment Status Credential.

Expected behavior
I would like to be able to follow the steps to issue Employment Status Credential in the readme with links that help me understand how (and why?) to execute each step.

@jiyoonie9 jiyoonie9 added the bug Something isn't working label May 3, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in SSI May 3, 2023
@decentralgabe decentralgabe added this to the BTC Miami milestone May 3, 2023
@decentralgabe decentralgabe moved this from 🆕 New to 🔖 Up Next in SSI May 3, 2023
@decentralgabe decentralgabe added the documentation Improvements or additions to documentation label May 3, 2023
@andresuribe87 andresuribe87 mentioned this issue May 8, 2023
@decentralgabe
Copy link
Member

Links are updated; though could be worth pointing them to specific commits/versions. Will have another task for that.

@github-project-automation github-project-automation bot moved this from 🔖 Up Next to ✅ Done in SSI May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants