You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
Intentionally creating a bit of a duplicate from #242 with the hope of focusing aim and consolidating consensus requirements
Close messages are valid after any message type
Close message introduces a new optional property success of type boolean
The logic of Close.success is as such:
if Close.success == null then that means Close was sent prior-to the Order execution
else if Close.success == true then Close was sent after a successful Order execution
else if Close.success == false then Close was sent after a failed Order execution
Close after Order
Close messages may be sent by Alice to the PFI during an actively executing order (AKA a state after, but not necessarily immediately after, an Order but prior to a Close where the Close.success is true), but that doesn't necessarily guarantee a successful canceled execution.
In the event Alice sends a Close message during an actively executing order:
if Close.success == true then Alice failed to cancel the executing order
else if Close.success == false then Alice successfully cancelled the executing order
We need to update the relevant spec docs here in this repo
We need to trickle through the changes through to various implementations
The text was updated successfully, but these errors were encountered:
@phoebe-lew are we actively labeling these for 1.0? This one doesn't have a label.
Edit: nevermind I see it now, it's a Deadline
Two parts to this:
Ensure the success property is within the Close message
Notify DRI's of the necessary changes for the given implementation (Note:Order messages are valid after any message, see description, so ensure that the various "valid next" calls enable that support)
Intentionally creating a bit of a duplicate from #242 with the hope of focusing aim and consolidating consensus requirements
Close
messages are valid after any message typeClose
message introduces a new optional propertysuccess
of type booleanThe logic of
Close.success
is as such:Close
afterOrder
Close
messages may be sent by Alice to the PFI during an actively executing order (AKA a state after, but not necessarily immediately after, anOrder
but prior to aClose
where theClose.success
istrue
), but that doesn't necessarily guarantee a successful canceled execution.In the event Alice sends a
Close
message during an actively executing order:The text was updated successfully, but these errors were encountered: