Remove danubech dependency from credential package 1/2 #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
+ Coverage 75.78% 76.24% +0.45%
==========================================
Files 43 45 +2
Lines 1900 2029 +129
Branches 342 361 +19
==========================================
+ Hits 1440 1547 +107
- Misses 313 321 +8
- Partials 147 161 +14
|
jiyoonie9
reviewed
Feb 16, 2024
credentials/src/main/kotlin/web5/sdk/credentials/StatusListCredential.kt
Show resolved
Hide resolved
jiyoonie9
reviewed
Feb 16, 2024
credentials/src/main/kotlin/web5/sdk/credentials/model/VcDataModel.kt
Outdated
Show resolved
Hide resolved
jiyoonie9
reviewed
Feb 16, 2024
credentials/src/main/kotlin/web5/sdk/credentials/StatusListCredential.kt
Show resolved
Hide resolved
jiyoonie9
reviewed
Feb 16, 2024
credentials/src/main/kotlin/web5/sdk/credentials/VerifiableCredential.kt
Show resolved
Hide resolved
nitro-neal
requested review from
amika-sq,
mistermoe,
tomdaffurn,
phoebe-lew,
diehuxx,
kirahsapong and
frankhinek
as code owners
jiyoonie9
reviewed
Mar 1, 2024
credentials/src/main/kotlin/web5/sdk/credentials/model/BitstringStatusListEntry.kt
Outdated
Show resolved
Hide resolved
jiyoonie9
reviewed
Mar 1, 2024
credentials/src/test/kotlin/web5/sdk/credentials/StatusListCredentialTest.kt
Outdated
Show resolved
Hide resolved
jiyoonie9
reviewed
Mar 1, 2024
jiyoonie9
reviewed
Mar 1, 2024
credentials/src/main/kotlin/web5/sdk/credentials/model/VcDataModel.kt
Outdated
Show resolved
Hide resolved
jiyoonie9
reviewed
Mar 1, 2024
nitro-neal
changed the title
nitro-neal
commented
Mar 7, 2024
credentials/src/main/kotlin/web5/sdk/credentials/model/VcDataModel.kt
Outdated
Show resolved
Hide resolved
jiyoonie9
approved these changes
Mar 9, 2024
credentials/src/main/kotlin/web5/sdk/credentials/model/VcDataModel.kt
Outdated
Show resolved
Hide resolved
credentials/src/main/kotlin/web5/sdk/credentials/model/VcDataModel.kt
Outdated
Show resolved
Hide resolved
credentials/src/test/kotlin/web5/sdk/credentials/StatusListCredentialTest.kt
Outdated
Show resolved
Hide resolved
|
it seems like we originally had updated to BitstringStatus thing but walked that back after clarifying the spec wording. could you remove the reference to Bitstring thingamabob in the original PR description markdown? |
jiyoonie9
reviewed
Mar 11, 2024
| private var id: URI? = null | ||
| private var context: MutableList<URI> = mutableListOf() | ||
| private var type: MutableList<String> = mutableListOf() | ||
| private lateinit var id: URI |
There was a problem hiding this comment.
could u explain why lateinit was added?
There was a problem hiding this comment.
Yea it was a kotlin thing giving me compile time errors, it wont allow non nullable properties to be left uninitialized. I could be using Kotlin feature wrong? but it seems like this is the only way to use the builder this way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove danubech dependency from credential package and use our own Vc Data Model
Description
This change allows us to have full control over our VcDataModel from danubech. This will allow us to easily upgrade to create a 2.0 data model and beyond and make sure we are compliant with our other sdks.