issue compiling with intel compiler (because of toml)

[Thomas-Ulrich]

I can compile tandem with gcc but not with intel compiler.
I mean, on supermuc,
spack install tandem polynomial_degree=3 domain_dimension=2 target=skylake_avx512

works, but not:

spack install tandem polynomial_degree=3 domain_dimension=2 target=skylake_avx512 %intel@21.4.0
See error log:

[+] /usr (external pkg-config-0.29.2-hkmzxgww4t733i4ukzmy76fnm44jrfph)
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/berkeley-db/18.1.40-intel-4xftmn2
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/libiconv/1.16-intel-uxci3js
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/zlib/1.2.11-intel-4gdhv2d
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/patchelf/0.13-intel-zjtgyaz
[+] /hppfs/work/pr63qo/di73yeq4/myLibs/spack-packages/linux-sles15-skylake_avx512/unzip/6.0-intel-21.4.0-hvf3isg
[+] /usr (external cpio-2.12.3-sorrvwo4gdqzpzdwon6r65lhsr3iw3ky)
==> [python@3.8.11](mailto:python@3.8.11) : has external module in ['python/3.8.11-extended']
[+] /lrz/sys/spack/release/22.2.1/views/python/3.8.11-extended (external python-3.8.11-qzdw77b42hrsgf57nu2dhjeiw7he7crs)
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/ncurses/6.2-intel-vv2uax3
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/diffutils/3.8-intel-27z2pt2
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/intel-mpi/2019.12.320-intel-asahktg
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/intel-mkl/2020.4.304-intel-jv5hnc6
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/readline/8.1-intel-z4z4etd
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/bzip2/1.0.8-intel-wvhtbyn
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/hypre/2.23.0-intel-napoi6a
[+] /hppfs/work/pr63qo/di73yeq4/myLibs/spack-packages/linux-sles15-skylake_avx512/lua/5.3.5-intel-21.4.0-x3xxakv
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/gdbm/1.19-intel-erzetqa
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/perl/5.34.0-intel-n24ahx3
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/openssl/1.1.1l-intel-gurlncr
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/cmake/3.21.4-intel-fgm4zzh
[+] /hppfs/work/pr63qo/di73yeq4/myLibs/spack-packages/linux-sles15-skylake_avx512/hdf5/1.10.7-intel-21.4.0-2h7lxjw
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/eigen/3.4.0-intel-ivdjmm7
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/metis/5.1.0-intel-4gr6lep
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/parmetis/4.0.3-intel-ucz5it6
[+] /hppfs/work/pr63qo/di73yeq4/myLibs/spack-packages/linux-sles15-skylake_avx512/mumps/5.4.0-intel-21.4.0-xv7ge27
[+] /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/superlu-dist/7.1.1-intel-ltdbxwd
[+] /hppfs/work/pr63qo/di73yeq4/myLibs/spack-packages/linux-sles15-skylake_avx512/petsc/3.17.2-intel-21.4.0-vt35sfq
==> Installing tandem-1.0-fdl3owqi6zggd6u4lv3ns5tlsg5dhr2b
==> No binary for tandem-1.0-fdl3owqi6zggd6u4lv3ns5tlsg5dhr2b found: installing from source
==> Using cached archive: /dss/dsshome1/0A/di73yeq4/spack/cache/_source-cache/git//TEAR-ERC/tandem.git/v1.0.tar.gz
==> Warning: Fetching from mirror without a checksum!
 This package is normally checked out from a version control system, but it has been archived on a spack mirror.  This means we cannot know a checksum for the tarball in advance. Be sure that your connection
to this mirror is secure!
==> Applied patch /hppfs/work/pr63qo/di73yeq4/seissol-spack-aid/spack/packages/tandem/fix_v1.0_compilation.diff
==> tandem: Executing phase: 'cmake'
==> tandem: Executing phase: 'build'
==> Error: ProcessError: Command exited with status 2:
   'make' '-j8'

106 errors found in build log:
    142    icpc: command line warning #10121: overriding '-march=skylake-avx512' with '-march=skylake-avx512'
    143    [  6%] Building CXX object src/CMakeFiles/tandem-fem-lib.dir/form/RefElement.cpp.o
    144    cd /hppfs/scratch/0A/di73yeq4/tmp/x86_avx512/spack-stage-tandem-1.0-fdl3owqi6zggd6u4lv3ns5tlsg5dhr2b/spack-build-fdl3owq/src && /dss/lrzsys/sys/spack/user/release/22.2.1/spack/lib/spack/env/intel/
           icpc  -I/hppfs/scratch/0A/di73yeq4/tmp/x86_avx512/spack-stage-tandem-1.0-fdl3owqi6zggd6u4lv3ns5tlsg5dhr2b/spack-src/src -isystem /dss/lrzsys/sys/spack/release/22.2.1/opt/skylake_avx512/eigen/3.4.0
           -intel-ivdjmm7/include/eigen3 -O2 -g -DNDEBUG -march=skylake-avx512 -MD -MT src/CMakeFiles/tandem-fem-lib.dir/form/RefElement.cpp.o -MF CMakeFiles/tandem-fem-lib.dir/form/RefElement.cpp.o.d -o CMa
           keFiles/tandem-fem-lib.dir/form/RefElement.cpp.o -c /hppfs/scratch/0A/di73yeq4/tmp/x86_avx512/spack-stage-tandem-1.0-fdl3owqi6zggd6u4lv3ns5tlsg5dhr2b/spack-src/src/form/RefElement.cpp
    145    icpc: command line warning #10121: overriding '-march=skylake-avx512' with '-march=skylake-avx512'
    146    In file included from /hppfs/scratch/0A/di73yeq4/tmp/x86_avx512/spack-stage-tandem-1.0-fdl3owqi6zggd6u4lv3ns5tlsg5dhr2b/spack-src/external/toml/toml.hpp(5),
    147                     from /hppfs/scratch/0A/di73yeq4/tmp/x86_avx512/spack-stage-tandem-1.0-fdl3owqi6zggd6u4lv3ns5tlsg5dhr2b/spack-src/external/toml/toml.cpp(2):
 >> 148    /hppfs/scratch/0A/di73yeq4/tmp/x86_avx512/spack-stage-tandem-1.0-fdl3owqi6zggd6u4lv3ns5tlsg5dhr2b/spack-src/external/toml/toml_impl.hpp(1127): error #77: this declaration has no storage class or t
           ype specifier                                                                                                                                                                                         
    149        TOML_ALWAYS_INLINE
    150        ^

Carsten suggest to have a look at: marzer/tomlplusplus#83
I tried updating toml to v2.5.0 and v3.3.0 but was not able to compile.
At the end, it is not a big problem, as we can compile with GCC, but I wanted to document the issue.

[Thomas-Ulrich]

Well after some tweaking, I was able to compile tandem with oneapi (the new intel compiler)

spack install -j 40 tandem polynomial_degree=3 domain_dimension=2 %oneapi ^unzip%gcc ^openssh%gcc ^bison%gcc

(I've opened issues for the ^unzip%gcc ^openssh%gcc ^bison%gcc, so in the future that may not be required)