Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build time #119

Closed
felipecrs opened this issue Mar 14, 2022 · 3 comments · Fixed by #228
Closed

Improve build time #119

felipecrs opened this issue Mar 14, 2022 · 3 comments · Fixed by #228

Comments

@felipecrs
Copy link
Collaborator

By implementing cache, as suggested by @nanosonde at #112 (comment).

@felipecrs
Copy link
Collaborator Author

Yes, we can implement cache. But the current Dockerfile isn't very cache friendly, we should ideally pin the version of all the apt-get dependencies.

#112 (comment)

@felipecrs
Copy link
Collaborator Author

It seems that the action we use already has builtin cache:

https://github.com/home-assistant/builder#publish-action-example

But it's only valid for merges to master, not for PRs or other branches.

In order to implement cache for all cases, we will need to switch away from the addon-builder to docker/build-and-push instead.

@felipecrs
Copy link
Collaborator Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant