Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key conversion rate issue #1783

Open
Konaya245 opened this issue Aug 16, 2024 · 0 comments
Open

Key conversion rate issue #1783

Konaya245 opened this issue Aug 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Konaya245
Copy link

Describe the bug

Old issue resurfacing. #272
Trade used my key selling rate when key is on their side of the trade, when trying to send change metal.

To Reproduce

Steps to reproduce the behavior:

  1. Set noticeable difference in key rate, eg. buy 10ref/sell 25ref
  2. Buyer only has key, no metals in inventory.
  3. Buyer buy an item using chat command.
  4. Bot sends offer for the key at their selling rate

Expected behavior

should be:

  • Use key selling price for conversion when the partner is taking keys from the bot
  • Use key buying price for conversion when the partner is giving keys to the bot

Screenshots and logs

Key rate: 56.55/86.22 ref
NC Tour of Duty Ticket - 25 ref / 25.11 ref
Guy canceled the trade and notified me of the issue.
1723811433574_07735872405489246

Other trades:
Screenshot 2024-08-02 224745
Screenshot 2024-08-02 224616

Version: v5.13.0

@Konaya245 Konaya245 added the bug Something isn't working label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant