Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mo files are not well generated #752

Open
Tofandel opened this issue Jul 13, 2018 · 9 comments
Open

Mo files are not well generated #752

Tofandel opened this issue Jul 13, 2018 · 9 comments

Comments

@Tofandel
Copy link

Tofandel commented Jul 13, 2018

Hi,

I noticed today that the mo files are not well compiled (at least for the french language)

The singular and plurals are concatenated together so I checked the po file and everything is in order, I recompiled it with poedit and then the translations started displaying correctly

I can provide the newly compiled mo file for Fr and other languages that might have the same issue as well if needed.

To reproduce => install a plugin with the latest version of tgmpa, requiring another plugin, with wordpress in french,
And notice that the string for "Begin to install the plugin" is : "Commencer à installer l'extensionCommencer à installer les extensions" instead of just "Commencer à installer l'extension"

@franzarmas
Copy link

Indeed, I have the same problem for the Spanish language (es_ES).

I also did the check with Poedit and after the compilation the translations start to work.

Please solve this in the future version.

@jrfnl
Copy link
Contributor

jrfnl commented Aug 28, 2018

@Tofandel @franzarmas We normally update the .po(t) files before each new release and regenerate the translation .mo files after translators have submitted any updates they want to provide. I'd be very happy if you'd be willing to test those files before we release the next version to prevent this issue.

@Tofandel
Copy link
Author

@jrfnl What tool do you use to regenerate them ?

@jrfnl
Copy link
Contributor

jrfnl commented Aug 28, 2018

@Tofandel If I remember correctly I used PoEdit originally, but the last batch may have been generated using https://github.com/phpmo/php.mo
It's been a while, so not entirely sure at the moment.

@cdmmultimedia
Copy link

We are having the same problem (i.e. weird plurals and singular sentences cobbled up together, and some translations falling back to the default). Regenerating the .mo files from the .po files fixed the issue.

@cdmmultimedia
Copy link

The library that you're mentioning seems to be no longer maintained. Do you need help with getting a reliable CI-enabled generation of the .mo files ?

@jrfnl
Copy link
Contributor

jrfnl commented May 30, 2019

@cdmmultimedia Help setting that up or even just documenting how we can do this easily in bulk would be awesome!

@cdmmultimedia
Copy link

cdmmultimedia commented May 31, 2019

@jrfnl We'd be happy to look into it :)

@jrfnl
Copy link
Contributor

jrfnl commented May 31, 2019

@cdmmultimedia Much appreciated! When you do, please keep in mind that maintainers may be on varying OS-es, i.e. both Linux/Mac as well as Windows will need to be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants