Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop or warn if a dataset doesn't exist? #93

Closed
katrinleinweber opened this issue Sep 5, 2018 · 0 comments
Closed

Stop or warn if a dataset doesn't exist? #93

katrinleinweber opened this issue Sep 5, 2018 · 0 comments

Comments

@katrinleinweber
Copy link
Collaborator

Currently, the use-case of downloading many datasets via bacdive_ids is hampered by the fact that some have return Not found. Probably, because BacDive deleted them on their end and/or assigned them a different ID.

if (identical(payload$detail, "Not found"))
{
stop(
"Your search returned no result, sorry. Please make sure that you provided a searchTerm, and specified the correct searchType. Please type '?retrieve_data' and read through the 'searchType' section to learn more."
)
}

could be changed to return a warning, an empty string, NULL, exactly Not found, etc. What would be most useful?

cc @jotech, @cameronmartino @ceb15: If you have an opinion or advice on this, it would be very welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant