Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow custom scaling of attachment thumbnail #417

Closed
adrian-herscu opened this issue Aug 29, 2019 · 7 comments
Closed

allow custom scaling of attachment thumbnail #417

adrian-herscu opened this issue Aug 29, 2019 · 7 comments
Milestone

Comments

@adrian-herscu
Copy link

For performance reasons, I am transforming my screenshots to use less colors and also scale them down to 1/4 so their sizes are now approx. 300x550 and weight less than 14KB.

Now I am discovering that the attachment thumbnails are no longer visible :(
This is due to hardcoded scaling value, currently set at 0.02.

@janschaefer
Copy link
Contributor

What would be a good solution? I think a fix thumbnail size would make more sense, right?

@adrian-herscu
Copy link
Author

What would be a good solution? I think a fix thumbnail size would make more sense, right?

I would say that this would be the cheapest solution :)

@janschaefer
Copy link
Contributor

What would be a good solution? I think a fix thumbnail size would make more sense, right?

@adrian-herscu
Copy link
Author

What would be a good solution? I think a fix thumbnail size would make more sense, right?

Sounds reasonable as long as it will display proportionally on different screen resolutions.

@janschaefer
Copy link
Contributor

I just looked into the code and it is already implemented that the thumbnail should have a minimal width and height of 20px. Maybe this is just too small?

@janschaefer
Copy link
Contributor

Ok, after understanding the code, I think the minimal size is not applied correctly...

@janschaefer janschaefer added this to the v0.18.0 milestone Aug 30, 2019
@janschaefer
Copy link
Contributor

Fix is released with v0.18.0. Can you verify that it works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants