Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broker audit -- ensure broker modules have proper form validation, testing, and documentation. #640

Open
15 of 40 tasks
jchate6 opened this issue Apr 25, 2023 · 8 comments · Fixed by #852
Open
15 of 40 tasks
Labels
Data Services Data Services Epic Overview topic for high level discussion

Comments

@jchate6
Copy link
Contributor

jchate6 commented Apr 25, 2023

Broker audit -- ensure broker modules have proper form validation, dependencies, testing, and documentation.

  • Install and configure each Broker on TOM Demo
    • ALeRCE --> tom_alerts
    • ANTARES --> tom_alerts
    • Lasair --> tom_alerts
    • Hermes --> tom_hermes
    • Scout --> tom_alerts (Not Including)
    • TNS --> tom_alerts
    • Fink --> tom_fink
    • Gaia --> tom_alerts
  • Check and update documentation
    • ALeRCE
    • ANTARES
    • Lasair
    • Hermes
    • Scout
    • TNS
    • Fink
    • Gaia
  • Test each broker to make sure it behaves as expected
    • ALeRCE
    • ANTARES
    • Lasair
    • Hermes
    • Scout
    • TNS
    • Fink
    • Gaia
  • Update Canary tests
    • ALeRCE
    • ANTARES
    • Lasair
    • Hermes
    • Scout
    • TNS
    • Fink
    • Gaia
  • address and/or prioritize broker issues
  • Investigate Pitt-Google Broker
  • Develop regular maintenance strategy
  • Review tom_alerts_dash
@jchate6 jchate6 converted this from a draft issue Apr 25, 2023
@jchate6 jchate6 moved this from Icebox to Backlog in TOM Toolkit Jun 30, 2023
@jchate6 jchate6 moved this from Backlog to In progress in TOM Toolkit Jul 7, 2023
@phycodurus phycodurus moved this from In progress to Backlog in TOM Toolkit Oct 24, 2023
@rachel3834 rachel3834 added the Epic Overview topic for high level discussion label Oct 30, 2023
@jchate6
Copy link
Contributor Author

jchate6 commented Nov 7, 2023

I'm failing to find any basic information about setting up a Broker (TNS, ALeRCE, Lasair, etc.) in the documentation.
This should be made more explicit.

For example,
TNS requires the following in settings.py:

BROKERS = {
    'TNS': {
        'api_key': TNS_API_KEY,
        'bot_id': <<bot_id>>,
        'bot_name': <<bot_name>>,
    }
}

@jchate6
Copy link
Contributor Author

jchate6 commented Jan 18, 2024

Related to TOMToolkit/tom_fink#24

@jchate6 jchate6 moved this from Triage to Backlog in TOM Toolkit Jan 19, 2024
@jchate6 jchate6 moved this from Backlog to Staged in TOM Toolkit Jan 19, 2024
@jchate6
Copy link
Contributor Author

jchate6 commented Jan 19, 2024

Look into more modern ways to access the Gaia Broker Data.

@jchate6
Copy link
Contributor Author

jchate6 commented Jan 20, 2024

Ensure Every Broker links to documentation. (Issue #271 )

@jchate6
Copy link
Contributor Author

jchate6 commented Jan 26, 2024

@jchate6
Copy link
Contributor Author

jchate6 commented Jan 26, 2024

Look into Pitt-Google Tom Broker
https://github.com/mwvgroup/tom_pittgoogle

@jchate6
Copy link
Contributor Author

jchate6 commented Jan 30, 2024

List of supported Brokers

  • ALeRCE
  • ANTARES
  • Lasair
  • Hermes
  • Scout
  • TNS
  • Fink
  • Gaia

@jchate6 jchate6 added the Data Services Data Services label Jan 31, 2024
@jchate6
Copy link
Contributor Author

jchate6 commented Jan 31, 2024

Also figure out what Scout (the Broker module) does.
(see ssd-api.jpl.nasa.gov/doc/scout.html) and document it.

  • document Scout Broker query form
  • add new parameters to Scout Broker query form as appropriate
  • Re-evaluate the use of scout Broker.

#837

@jchate6 jchate6 moved this from Staged to In progress in TOM Toolkit Feb 2, 2024
@jchate6 jchate6 linked a pull request Feb 24, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In progress to Closed in TOM Toolkit Feb 28, 2024
@jchate6 jchate6 reopened this Feb 28, 2024
@github-project-automation github-project-automation bot moved this from Closed to Triage in TOM Toolkit Feb 28, 2024
@phycodurus phycodurus moved this from Triage to Backlog in TOM Toolkit Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Services Data Services Epic Overview topic for high level discussion
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants