Continous Use: Reimplemented #1645
Conversation
|
Not sure that all those actions were continously useable before my rework. Also I'd normally have said, that those actions are triggered every frame. 0.1s seems a bit weird. But I am not sure how the timing was before, but it should probably be tickrate dependent. And every implementation of continuos use should do some deltaTime calcs to make sure the amount is tickrate independent. |
Some of them are exited early, so are map entities withou continous use. I'm not sure how I could handle the rest, but I guess it is identical to how it was before? If you have any ideas, go ahead. And yes, I could change to timer ot every tick (0 time) as well. I wasn't sure what the best interval here would be |
|
@ZenBre4ker Judging by this: and this: I think it is safe to assume that it was handled every frame before. Now I'm wondering if a 0 tick timer would be a good solution here. Or if I should handle it in the Think hook as well. |
|
0 tick timer should suffice. But I will take a look at the continuous use for the other interactions. Feel free to merge this if you tested it, as I wont promise to come up with an analysis early. The following idea is meant as an enhancement and therefore should not be taken into consideration for this MR: Im actually thinking about reverting it a little, so to return true on serverside use again. This would bring the old behavior back in most cases and only add the feature that the client can argue that there is an entity to use. To not double activate use, we could cache used ents to see if Use was triggered on the server already. It could be complicated though, therefore its just an idea. |
|
I tested it and put it into today's release candidate. We will see what the feedback is |
| if self:IsWeapon() or self.player_ragdoll then | ||
| return true | ||
| elseif self:IsScripted() and self.CanUseKey then |
There was a problem hiding this comment.
| if self:IsWeapon() or self.player_ragdoll then | |
| return true | |
| elseif self:IsScripted() and self.CanUseKey then | |
| if self:IsWeapon() or self.player_ragdoll or (self:IsScripted() and self.CanUseKey) then |
There was a problem hiding this comment.
Not sure anymore if the brackets are needed.
There was a problem hiding this comment.
I split this into two because I thought it is more readable
There was a problem hiding this comment.
i second zen's approach. 2 ifs are more confusing IMO
also the parenthesis should not be needed
| end | ||
|
|
||
| -- make sure it is called 10 times per second | ||
| timer.Simple(0.1, function() |
There was a problem hiding this comment.
Agreed, but I have to test this to see if that works
There was a problem hiding this comment.
This sadly does not work
Edit: setting the timer to 0 i mean; 0.1 instead works flawlessly
Fixes #1636
Due to the use rework, continuous use was broken. This PR fixes it by adding a timer that is called as long as the use key is pressed and the entity is close by.
Most of these changes are just code being moved into another function, the timer part is new though