Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grabbit fails sync when node name contains '$' sign #213

Open
dbugrimov opened this issue Aug 27, 2018 · 2 comments
Open

Grabbit fails sync when node name contains '$' sign #213

dbugrimov opened this issue Aug 27, 2018 · 2 comments

Comments

@dbugrimov
Copy link

dbugrimov commented Aug 27, 2018

Syncing DAM Assets I came across an issue when Grabbit throws an exception meeting '$' sign in a node name.

Code with issue:
/src/main/groovy/com/twcable/grabbit/jcr/DefaultProtoNodeDecorator.groovy
Line 58: createFrom(childNode, childNode.getName().replaceFirst(Pattern.quote(innerProtoNode.name), getName())).writeToJcr(session)

when getName() returns a node name with '$' sign in it, replaceFirst treats it as a capturing group reference in the replacement string and throws an exception

@djessup
Copy link

djessup commented Sep 10, 2018

I too have run into this. I'd argue if a node has a valid JCR name it should be taken as-if and not interpreted unless an option explicitly says so.

@ElmiraZhernova
Copy link

Here is pull request , that fixes this issue #224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants