Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The destroying on unmount is too aggressive #156

Closed
ZachHandley opened this issue Oct 15, 2024 · 2 comments · Fixed by #157
Closed

The destroying on unmount is too aggressive #156

ZachHandley opened this issue Oct 15, 2024 · 2 comments · Fixed by #157

Comments

@ZachHandley
Copy link

I am trying to use this in a multi-stepped process with a PDF, and it keeps destroying the entire damn source ref from the parent component along with the PDF component. I am literally just trying to show it on two different pages, and it's aggressively destroying the source so. I can fetch it on each step (a 7+MB PDF) or I can ??? -- it would be great if we got to decide when to destroy it

@TaTo30
Copy link
Owner

TaTo30 commented Oct 18, 2024

Destroy source was added to solve some performance issues, but you are right that it could be aggressive and upredictable, I will add an optional prop like auto-destroy to let the developer decide. Meanwhile you could use v-show instead of v-if to make your project works.

@ZachHandley
Copy link
Author

Thanks man I appreciate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants