-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
div "container" overflow:hidden prevents horizontal scroll #99
Comments
Hi, @dfidler ! I have the same issue when I use this component. My temporary solution is as follows, using <VuePDF
:style="{ overflow: 'visible' }"
:pdf="pdf"
:page="page"
/> |
But.. but.. I tried that! 🤣 Actually, I tried...
... which is basically the same thing... and it wasn't working ... until I tried yours and it worked and it blew my mind so I put mine back (like above) and it works now. 🤦 I don't get it. The overflow value would "take" on first load but then when I started scaling it would get overwritten... but I looked at the code and couldn't figure out how it was getting set again because I couldn't see where it was getting added in the code. Anyway, looking at the above, I wouldn't believe me either so... I dunno, I must have been doing something stupid. Maybe I just needed some sleep. Clearly I need to find a vocation more suited to my capabilities - anyone know of any jobs involving staring at a blank wall all day?🤣 Thanks for the help. 😄 |
Hahaha, looks tricky 😃 This is an article in Japanese, but it might be of some help! From this article, in Vue 3.x, the second property override the first property. btw, it's the opposite specification in Vue 2.x. 🤣 <!-- template -->
<div id="red" v-bind="{ id: 'blue' }"></div>
<!-- result -->
<div id="blue"></div>
<!-- template -->
<div v-bind="{ id: 'blue' }" id="red"></div>
<!-- result -->
<div id="red"></div> |
There were some issues with the overflow in the early versions but they are all fixed now so Thank you! @kazuki-komori for the support there. |
Amazing! Thanks to both of you 👍 |
I'm trying to implement a pdf viewer with thumbnails (which works) except I can't get it to scale properly in such a way that i can enable horizontal scroll.
It looks like the "overflow: hidden" in the "container" div is the culprit. I'm not the best Vue developer on earth so maybe there's a way that I can use some scoped styling to override that but so far, sending in classes and styles to VuePDF aren't helping. I can see that the container is being used to define --scale-factor but does it really need overflow: hidden?
I can enable horizontal scroll the moment I remove container.{overflow: hidden} (in dev tools) But maybe I'm just missing something really basic.
vue-pdf/src/components/VuePDF.vue
Lines 297 to 299 in 86ae153
Additional context
The text was updated successfully, but these errors were encountered: