feat: more tests

Author: Computerdores

tagstudio/src/core/query_lang/ast.py

@@ -103,24 +103,24 @@ def visit(self, node: AST) -> T:
             return self.visit_property(node)
         elif isinstance(node, Not):
             return self.visit_not(node)
-        raise Exception(f"Unknown Node Type of {node}")
+        raise Exception(f"Unknown Node Type of {node}")  # pragma: nocover
 
     @abstractmethod
     def visit_and_list(self, node: ANDList) -> T:
-        raise NotImplementedError()
+        raise NotImplementedError()  # pragma: nocover
 
     @abstractmethod
     def visit_or_list(self, node: ORList) -> T:
-        raise NotImplementedError()
+        raise NotImplementedError()  # pragma: nocover
 
     @abstractmethod
     def visit_constraint(self, node: Constraint) -> T:
-        raise NotImplementedError()
+        raise NotImplementedError()  # pragma: nocover
 
     @abstractmethod
     def visit_property(self, node: Property) -> T:
-        raise NotImplementedError()
+        raise NotImplementedError()  # pragma: nocover
 
     @abstractmethod
     def visit_not(self, node: Not) -> T:
-        raise NotImplementedError()
+        raise NotImplementedError()  # pragma: nocover

tagstudio/src/core/query_lang/tokenizer.py

@@ -41,10 +41,10 @@ def EOF() -> "Token":  # noqa: N802
         return Token.from_type(TokenType.EOF)
 
     def __str__(self) -> str:
-        return f"Token({self.type}, {self.value}, {self.start}, {self.end})"
+        return f"Token({self.type}, {self.value}, {self.start}, {self.end})"  # pragma: nocover
 
     def __repr__(self) -> str:
-        return self.__str__()
+        return self.__str__()  # pragma: nocover
 
 
 class Tokenizer:

tagstudio/src/core/query_lang/util.py

@@ -9,7 +9,7 @@ def __init__(self, start: int, end: int, msg: str = "Syntax Error") -> None:
         self.msg = msg
 
     def __str__(self) -> str:
-        return f"Syntax Error {self.start}->{self.end}: {self.msg}"
+        return f"Syntax Error {self.start}->{self.end}: {self.msg}"  # pragma: nocover
 
     def __repr__(self) -> str:
-        return self.__str__()
+        return self.__str__()  # pragma: nocover

tagstudio/tests/conftest.py

@@ -120,7 +120,7 @@ def library(request):
 @pytest.fixture
 def search_library() -> Library:
     lib = Library()
-    lib.open_library(pathlib.Path("./tagstudio/tests/fixtures/search_library"))
+    lib.open_library(pathlib.Path(CWD / "fixtures" / "search_library"))
     return lib
 
 

tagstudio/tests/test_search.py

@@ -1,6 +1,7 @@
 import pytest
 from src.core.library.alchemy.enums import FilterState
 from src.core.library.alchemy.library import Library
+from src.core.query_lang.util import ParsingError
 
 
 def verify_count(lib: Library, query: str, count: int):
@@ -19,6 +20,7 @@ def verify_count(lib: Library, query: str, count: int):
         ("special:untagged", 1),
         ("filetype:png", 23),
         ("filetype:jpg", 6),
+        ("filetype:'jpg'", 6),
         ("tag_id:1011", 5),
         ("tag_id:1038", 11),
         ("doesnt exist", 0),
@@ -72,3 +74,51 @@ def test_and(search_library: Library, query: str, count: int):
 )
 def test_or(search_library: Library, query: str, count: int):
     verify_count(search_library, query, count)
+
+
+@pytest.mark.parametrize(
+    ["query", "count"],
+    [
+        ("not unexistant", 29),
+        ("not path:*", 0),
+        ("not not path:*", 29),
+        ("not special:untagged", 28),
+        ("not filetype:png", 6),
+        ("not filetype:jpg", 23),
+        ("not tag_id:1011", 24),
+        ("not tag_id:1038", 18),
+        ("not green", 24),
+        ("tag:favorite", 0),
+        ("not circle", 18),
+        ("not tag:square", 18),
+        ("circle and not square", 6),
+        ("not circle and square", 6),
+        ("special:untagged or not filetype:jpg", 24),
+        ("not square or green", 20),
+    ],
+)
+def test_not(search_library: Library, query: str, count: int):
+    verify_count(search_library, query, count)
+
+
+@pytest.mark.parametrize(
+    ["query", "count"],
+    [
+        ("(tag_id:1041)", 11),
+        ("(((tag_id:1041)))", 11),
+        ("not (not tag_id:1041)", 11),
+        ("((circle) and (not square))", 6),
+        ("(not ((square) OR (green)))", 15),
+        ("filetype:png and (tag:square or green)", 12),
+    ],
+)
+def test_parentheses(search_library: Library, query: str, count: int):
+    verify_count(search_library, query, count)
+
+
+@pytest.mark.parametrize(
+    "invalid_query", ["asd AND", "asd AND AND", "tag:(", "(asd", "asd[]", "asd]", ":", "tag: :"]
+)
+def test_syntax(search_library: Library, invalid_query: str):
+    with pytest.raises(ParsingError) as e_info:  # noqa: F841
+        search_library.search_library(FilterState.from_search_query(invalid_query))