Skip to content

Commit e9d8912

Browse files
fix: type hint fixes
1 parent 4eca516 commit e9d8912

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

tagstudio/src/qt/ts_qt.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -784,7 +784,7 @@ def run_macros(self, name: MacroID, grid_idx: list[int]):
784784

785785
def run_macro(self, name: MacroID, grid_idx: int):
786786
"""Run a specific Macro on an Entry given a Macro name."""
787-
entry: Entry = self.frame_content[grid_idx]
787+
entry: Entry | None = self.frame_content[grid_idx]
788788
assert self.lib.library_dir is not None and entry is not None
789789
full_path = self.lib.library_dir / entry.path
790790
source = "" if entry.path.parent == Path(".") else entry.path.parts[0].lower()

tagstudio/tests/test_library.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ def test_library_get_alias(library, generate_tag):
3636
alias_names.add("test_alias")
3737
library.update_tag(tag, subtag_ids, alias_names, alias_ids)
3838

39-
alias_ids = library.get_tag(tag.id).alias_ids
39+
_alias_ids = library.get_tag(tag.id).alias_ids
4040

41-
assert library.get_alias(tag.id, alias_ids[0]).name == "test_alias"
41+
assert library.get_alias(tag.id, _alias_ids[0]).name == "test_alias"
4242

4343

4444
def test_library_update_alias(library, generate_tag):
@@ -52,9 +52,9 @@ def test_library_update_alias(library, generate_tag):
5252
library.update_tag(tag, subtag_ids, alias_names, alias_ids)
5353

5454
tag = library.get_tag(tag.id)
55-
alias_ids = tag.alias_ids
55+
_alias_ids = tag.alias_ids
5656

57-
assert library.get_alias(tag.id, alias_ids[0]).name == "test_alias"
57+
assert library.get_alias(tag.id, _alias_ids[0]).name == "test_alias"
5858

5959
alias_names.remove("test_alias")
6060
alias_names.add("alias_update")
@@ -191,6 +191,7 @@ def test_add_field_tag(library: Library, entry_full, generate_tag):
191191

192192
# Then
193193
result = library.get_entry_full(entry_full.id)
194+
assert result is not None
194195
tag_field = result.tag_box_fields[0]
195196
assert [x.name for x in tag_field.tags if x.name == tag_name]
196197

@@ -320,6 +321,7 @@ def test_update_entry_with_multiple_identical_fields(library, entry_full):
320321

321322

322323
def test_mirror_entry_fields(library: Library, entry_full):
324+
assert library.folder is not None
323325
# new entry
324326
target_entry = Entry(
325327
folder=library.folder,
@@ -338,12 +340,14 @@ def test_mirror_entry_fields(library: Library, entry_full):
338340

339341
# get new entry from library
340342
new_entry = library.get_entry_full(entry_id)
343+
assert new_entry is not None
341344

342345
# mirror fields onto new entry
343346
library.mirror_entry_fields(new_entry, entry_full)
344347

345348
# get new entry from library again
346349
entry = library.get_entry_full(entry_id)
350+
assert entry is not None
347351

348352
# make sure fields are there after getting it from the library again
349353
assert len(entry.fields) == 4

0 commit comments

Comments
 (0)