Migrations: Remove empty "commands" field from settings completely.

Author: Taitava

src/Migrations.ts

@@ -5,6 +5,7 @@ export async function RunMigrations(plugin: ShellCommandsPlugin) {
     let save = MigrateCommandsToShellCommands(plugin);
     save ||= MigrateShellCommandToPlatforms(plugin);
     save ||= EnsureShellCommandsHaveAllFields(plugin);
+    save ||= DeleteEmptyCommandsField(plugin);
     if (save) {
         // Only save if there were changes to configuration.
         console.log("Saving migrations...")
@@ -14,6 +15,9 @@ export async function RunMigrations(plugin: ShellCommandsPlugin) {
 }
 
 function MigrateCommandsToShellCommands(plugin: ShellCommandsPlugin) {
+    if (undefined === plugin.settings.commands) {
+        return false;
+    }
     let count_shell_commands = plugin.settings.commands.length;
     let save = false;
     if (0 < count_shell_commands) {
@@ -99,4 +103,21 @@ function MigrateShellCommandToPlatforms(plugin: ShellCommandsPlugin) {
         }
     }
     return save;
+}
+
+/**
+ * Can be removed in 1.0.0.
+ *
+ * @param plugin
+ * @constructor
+ */
+function DeleteEmptyCommandsField(plugin: ShellCommandsPlugin) {
+    let save = false;
+    if (undefined !== plugin.settings.commands) {
+        if (plugin.settings.commands.length === 0) {
+            delete plugin.settings.commands;
+            save = true;
+        }
+    }
+    return save;
 }

src/settings/ShellCommandsPluginSettings.ts

@@ -11,7 +11,7 @@ export interface ShellCommandsPluginSettings {
 
     // Legacy:
     /** @deprecated Use shell_commands object instead of this array. From now on, this array can be used only for migrating old configuration to shell_commands.*/
-    commands: string[];
+    commands?: string[];
 }
 
 export const DEFAULT_SETTINGS: ShellCommandsPluginSettings = {
@@ -21,9 +21,6 @@ export const DEFAULT_SETTINGS: ShellCommandsPluginSettings = {
     shell_commands: {},
     error_message_duration: 20,
     notification_message_duration: 10,
-
-    // Legacy:
-    commands: [] // Deprecated, but must be present in the default values as long as migrating from commands to shell_commands is supported.
 }
 
 /**