ESLint: Always require semicolons.

OutputChannelCode: Removed an unnecessary semicolon.

CreateShellSelectionField: In addition to adding a semicolon, also made the nested function cleaner with newlines and indentation.

I didn't create an issue or discussion for this.

Author: Taitava

.eslintrc

@@ -21,6 +21,7 @@
 		"@typescript-eslint/ban-ts-comment": "off",
 		"no-prototype-builtins": "off",
 		"@typescript-eslint/no-empty-function": "off",
-        "@typescript-eslint/no-inferrable-types": "off"
+        "@typescript-eslint/no-inferrable-types": "off",
+        "semi": ["error", "always"]
 	}
 }

src/Common.ts

@@ -154,7 +154,7 @@ export function normalizePath2(path: string) {
     const leading_slashes_array = leading_slashes_regexp.exec(path); // An array with only one item.
     if (null === leading_slashes_array) {
         // It should always match. This exception should never happen, but have it just in case.
-        throw new Error("normalizePath2(): leading_slashes_regexp did not match.")
+        throw new Error("normalizePath2(): leading_slashes_regexp did not match.");
     }
     let leading_slashes = leading_slashes_array[0];
 
@@ -271,7 +271,7 @@ export function prepareEditorPosition(editor: Editor, caret_line: number, caret_
     return {
         line: caret_line,
         ch: caret_column,
-    }
+    };
 }
 
 export function getSelectionFromTextarea(textarea_element: HTMLTextAreaElement, return_null_if_empty: true): string | null;

src/Hotkeys.ts

@@ -29,13 +29,13 @@ export function getHotkeysForShellCommand(plugin: SC_Plugin, shell_command_id: s
     // @ts-ignore
     const app_custom_hotkeys = plugin.app.hotkeyManager?.customKeys;
     if (!app_custom_hotkeys) {
-        debugLog("getHotkeysForShellCommand() failed, will return an empty array.")
+        debugLog("getHotkeysForShellCommand() failed, will return an empty array.");
         return [];
     }
 
     // Get only our hotkeys.
     const hotkey_index = plugin.getPluginId() + ":" + plugin.generateObsidianCommandId(shell_command_id); // E.g. "obsidian-shellcommands:shell-command-0"
-    debugLog("getHotkeysForShellCommand() succeeded.")
+    debugLog("getHotkeysForShellCommand() succeeded.");
     return app_custom_hotkeys[hotkey_index] ?? []; // If no hotkey array is set for this command, return an empty array. Although I do believe that all commands do have an array anyway, but have this check just in case.
 }
 
@@ -60,5 +60,5 @@ export function HotkeyToString(hotkey: Hotkey) {
 }
 
 export function CmdOrCtrl(): "Cmd" | "Ctrl" {
-    return Platform.isMacOS ? "Cmd" : "Ctrl"
+    return Platform.isMacOS ? "Cmd" : "Ctrl";
 }

src/Migrations.ts

@@ -42,10 +42,10 @@ export async function RunMigrations(plugin: SC_Plugin) {
     ];
     if (should_save.includes(true)) {
         // Only save if there were changes to configuration.
-        debugLog("Saving migrations...")
+        debugLog("Saving migrations...");
         backupSettingsFile(plugin); // Make a backup copy of the old file BEFORE writing the new, migrated settings file.
         await plugin.saveSettings();
-        debugLog("Migrations saved...")
+        debugLog("Migrations saved...");
     }
 }
 

src/Shell.ts

@@ -35,7 +35,7 @@ export const PlatformShells = {
         "PowerShell.exe": "PowerShell 5",
         "CMD.EXE": "cmd.exe",
     },
-}
+};
 
 export function getUsersDefaultShell(): string {
     if (isWindows()) {

src/ShellCommandExecutor.ts

@@ -171,12 +171,12 @@ export class ShellCommandExecutor {
                     this.executeShellCommand(shell_command_parsing_result, overriding_output_channel);
                 } else {
                     // Parsing has failed.
-                    debugLog("Parsing the rest of the variables failed.")
+                    debugLog("Parsing the rest of the variables failed.");
                     parsing_process.displayErrorMessages();
                 }
             } else {
                 // Cancel execution
-                debugLog("Shell command execution cancelled.")
+                debugLog("Shell command execution cancelled.");
             }
         });
 
@@ -200,7 +200,7 @@ export class ShellCommandExecutor {
            outputChannels = {
                'stdout': overriding_output_channel,
                'stderr': overriding_output_channel,
-           }
+           };
         }
 
         // Check that the shell command is not empty

src/events/SC_AbstractFileMenuEvent.ts

@@ -39,7 +39,7 @@ export abstract class SC_AbstractFileMenuEvent extends SC_MenuEvent {
                         this.file = file as TFile;
                         break;
                     case "folder":
-                        this.folder = file as TFolder
+                        this.folder = file as TFolder;
                         break;
                 }
 

src/events/SC_Event.ts

@@ -81,7 +81,7 @@ export abstract class SC_Event {
      */
     private subclass_instance: this;
     public getClass() {
-        return this.subclass_instance.constructor as typeof SC_Event
+        return this.subclass_instance.constructor as typeof SC_Event;
     }
 
     public canRegisterAfterChangingSettings(): boolean {
@@ -176,7 +176,7 @@ export abstract class SC_Event {
     public getDefaultConfiguration(enabled: boolean): SC_EventConfiguration {
         const configuration = cloneObject<SC_EventConfiguration>(this.default_configuration);
         configuration.enabled = enabled;
-        return configuration
+        return configuration;
     }
 
     protected getConfiguration(t_shell_command: TShellCommand) {

src/events/SC_Event_EveryNSeconds.ts

@@ -75,11 +75,11 @@ export class SC_Event_EveryNSeconds extends SC_Event {
                 .setButtonText("Apply")
                 .onClick(async () => {
                     if (undefined == apply_seconds || apply_seconds === this.getConfiguration(t_shell_command).seconds) {
-                        new Notice("You didn't change the seconds!")
+                        new Notice("You didn't change the seconds!");
                     } else if (isNaN(apply_seconds)) {
-                        new Notice("The seconds need to be an integer!")
+                        new Notice("The seconds need to be an integer!");
                     } else if (apply_seconds <= 0) {
-                        new Notice("The seconds need to be at least 1!")
+                        new Notice("The seconds need to be at least 1!");
                     } else {
                         // All ok, save.
                         this.getConfiguration(t_shell_command).seconds = apply_seconds;

src/events/SC_VaultEvent.ts

@@ -62,7 +62,7 @@ export abstract class SC_VaultEvent extends SC_Event {
                         this.file = file as TFile;
                         break;
                     case "folder":
-                        this.folder = file as TFolder
+                        this.folder = file as TFolder;
                         break;
                 }