-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using setServerNames on WebSocket #201
Comments
@MinnDevelopment Thank you. I'm interested in what your PR will look like 😀 . Please note that I'm a bit picky about beauty of source codes, so PRs that "just work" won't be merged 😅 . My programming style can be found in repositories in github.com/authlete and github.com/TakahikoKawasaki. Finally, I'm sorry I'm busy as a co-founder and programmer of Authlete, Inc., so it may take time for me to respond. |
@TakahikoKawasaki I already have something but I haven't gotten around to testing it yet. I will try my best to adhere to the code style. |
@MinnDevelopment Thank you for your PR! nv-websocket-client 2.10 including your PR was released. I hope the release will appear in the Maven central repository soon. |
Currently, you have to use
WebSocketFactory#setServerNames
for SNI parameters. However, I want to use the factory for different connections to different domains. This requires doing synchronization on the factory only to set the server name:I have 3 solutions to this problem with decreasing complexity:
createSocket
to have an idempotent behaviornew WebSocketFactory(otherFactory)
or similar. I would be willing to PR this.The text was updated successfully, but these errors were encountered: