Only dump schema after migrating in development environment.

[dividedmind]

Currently schema is always dumped after migration when the environment isn't a test environment. This is troublesome, because it means it's dumped in production; aside from not being useful, this breaks when the filesystem is read-only(-ish), like on Heroku. Ordinarily this is not obvious, but if you're running some scripts heroku-side you'll note that rake db:migrate returns nonzero error code. This patch fixes the issue by only dumping schema in development, arguably the only environment where it makes sense anyway.

[JonathanTron]

Hi @dividedmind, sorry for taking so long to reply.

I get your point, but I'm not sure we should do anything about it.

I've encountered some scenarios with expectations that the schema.rb/structure.sql file will be generated in environments other than development.

I'm wondering if a better solution would not be to add a configuration for it, something like: exclude_environments_dump , with a default to [:test]. And then use this to determine if we should dump or not the schema/structure.

What do you think?

[dividedmind]

I think it's simpler to add a sequel.schema_format = :none, and adjust the defaults accordingly.

Another option is to just add | Rails.env.production? to the original code. While I understand there can be environments outside of development that use dumping, if you're relying on schema dumping in production you're obviously doing something wrong.

[JonathanTron]

I really like your idea of using sequel.schema_format = :none. I prefer to limit the hard-coded assumption about the environment (test is already a smell).

[dividedmind]

Agreed :)

[dividedmind]

Ah, wait, it won't work! We need schema_format for loading, too.

[dividedmind]

How about this?

[JonathanTron]

This looks awesome!