-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI gets stuck when adding --add-ons shadcn
#28
Comments
Same here +1 |
Shadcn is the only add-on that runs a command. So a couple of questions:
|
I went and tested running I then went and created a new project with Just a thought, but maybe you need to add resolve: {
alias: {
"@": path.resolve(__dirname, "./src"),
},
}, to (as well as ensure Tailwind is installed and setup before prior) |
We definitely do add:
To the vite.config.ts if shadcn is enabled. I'm kinda considering just adding it all the time as its super handy. I haven't see the React 19 warning. Interesting. If you add the Worst case scenario I can just remove the |
Even with ![]() It looks like it is just an issue with |
I think I see what's happening. This is creating a new Next.js app. Yeah, to repro we really need to run that I think the best thing to do is for me to just apply the patches that it makes manually in the add-on. |
Deep sigh. Well, I still thin the best thing to do is not run the command and to apply the patches myself. That's what we do for |
Ok, should definitely be fixed now since we are no longer running the init command. Be sure to use |
@jherr Yep that fixed it. I now see the same issue happening when the CLI is trying to add shadcn components once ![]() |
Ok, different issue, same source-ish, which is running commands. My only thought is that somehow the CWD is set wrong. Are you running on Windows or something? Is there some way the CWD could be set incorrectly? |
I'm on Mac, pretty standard shell setup. Let me try on another Macbook and see if I have the same issue. |
Be sure to test the 0.4.2 version because 0.4.3 removes the request to load Is it possible that you don't have NPX? |
What's your node version? Not having |
Ok. Gonna have to put in a node version check. Otherwise I'll keep chasing bugs like this down a rabbit hole. My guess is that this was the underlying problem with the original |
Well all my screenshots and testing before was with LTS. It was just that second laptop that was using Node 18. So there is still the hanging issue with Node LTS and the shadcn CLI stuff. |
I don't understand. Neither shadcn, nor start are doing any installs anymore. Besides the package manager install at the end. |
Oh i was saying with |
Ah, ok. |
I think the issue is due to multiple --add-ons. npx create-tsrouter-app@latest --template file-router --add-ons tanstack-query
npx create-tsrouter-app@latest --template file-router --add-ons shadcn NOT Working npx create-tsrouter-app@latest --template file-router --add-ons tanstack-query,shadcn Notice the add-ons list parameter is the issue. |
I ran this with the latest version (0.4.3) and it worked! pnpx create-tsrouter-app@latest frontend --template file-router --tailwind --package-manager pnpm --no-git --add-ons shadcn,tanstack-query |
Which project does this relate to?
Create Tanstack App
Describe the bug
When running the following command:
npx create-tsrouter-app@latest --add-ons shadcn
the CLI seems to hang infinitely on
Setting up Shadcn...
as shown below:Your Example Website or App
N/A
Steps to Reproduce the Bug or Issue
npx create-tsrouter-app@latest --add-ons shadcn
from the TerminalExpected behavior
As a user, I expected the CLI to correctly set up Shadcn but I am seeing it stuck on "Setting up Shadcn..." and no warning or error is printed.
Screenshots or Videos
See above
Platform
The text was updated successfully, but these errors were encountered: