Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change FieldAPI onMount to match other validation function typings #429

Closed
3 tasks
crutchcorn opened this issue Sep 2, 2023 · 3 comments
Closed
3 tasks
Labels

Comments

@crutchcorn
Copy link
Member

crutchcorn commented Sep 2, 2023

Right now, onMount appears to be a non-validation function for FieldAPI, which I find a bit confusing given that the form itself has an onMount and onMountAsync

Instead, let's change it to pass value and formApi and use it within validateAsync like other validation methods.

Goals

  • Add support for onMountAsync
  • Update reference docs
  • Add integration tests
@crutchcorn crutchcorn changed the title Change onMount to match other validation function typings Change FieldAPI onMount to match other validation function typings Sep 2, 2023
@juliendelort
Copy link
Contributor

I'm down to work on this, can it be assigned to me?

@crutchcorn
Copy link
Member Author

Hey @juliendelort! Admittedly, I think we should hold off on this issue until #462 is merged, as it makes substantial changes to how validation works. It might be a bit of a headache to manage duplicate work in this space 😅

That said, I see that you have your own forms library, which looks great in its own right! I'd love to collab in big ways!

I just shot you a DM on Twitter - let's chat more about how we can merge efforts to make forms awesome!

@crutchcorn
Copy link
Member Author

This change should be made part of the larger changes here:

#491

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants