Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When used in conjunction with the latest version of "vite-plugin-vue-devtools@7.0.3," there may be an error. #6632

Closed
whyfail opened this issue Jan 3, 2024 · 3 comments · Fixed by #7145

Comments

@whyfail
Copy link

whyfail commented Jan 3, 2024

Describe the bug

In a Vite project, when using both "@tanstack/vue-query": "^5.17.0" and "vite-plugin-vue-devtools": "^7.0.3" simultaneously, there may be an error upon starting the project.

This results in my "vite-plugin-vue-devtools" being unable to function properly.

Your minimal, reproducible example

https://codesandbox.io/p/devbox/tanstack-vue-query-7d2xj6

Steps to reproduce

Open the console and you'll see an error message

image

Expected behavior

Open the console and you'll see an error message

How often does this bug happen?

None

Screenshots or Videos

No response

Platform

window11
Google Chrome:119.0.6045.159
vue:3.4.3
vite:5.0.10

Tanstack Query adapter

None

TanStack Query version

v5.17.0

TypeScript version

No response

Additional context

No response

@TkDodo
Copy link
Collaborator

TkDodo commented Jan 28, 2024

@DamianOsipiuk fyi

@DamianOsipiuk
Copy link
Contributor

@whyfail Since this is a breaking change in the devtools rewrite, we cannot do to much from our side actually.
What we could do is to offer a way to disable the devtools plugin. Or maybe even disable it by default, and offer enable flag? 🤔

And for the future, since now there are a lot of devtools creating (nuxt, vite, vue) i think that we should eventually remove it from the lib itself.
It was ok, when there was only one official vue devtools, but now people can choose from many.

We offer component-based devtools that should be always up-to-date, and if someone wants to hook to other offered by their framework, it should be up to the community to maintain those integrations.

@StefanFlaschko
Copy link

So, how to enable the devtools if I want to use it. In the documentary, there are no hints on how to do it: https://tanstack.com/query/v4/docs/framework/vue/devtools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants