test(router): wait for nav to complete (#5744)

Author: birkskyum

packages/react-router/tests/link.test.tsx

@@ -748,6 +748,11 @@ describe('Link', () => {
 
     await act(() => fireEvent.click(updateSearchLink))
 
+    // Wait for navigation to complete and search params to update
+    await waitFor(() => {
+      expect(window.location.search).toBe('?page=2&filter=inactive')
+    })
+
     // Verify search was updated
     expect(window.location.pathname).toBe('/posts')
     expect(window.location.search).toBe('?page=2&filter=inactive')
@@ -860,6 +865,11 @@ describe('Link', () => {
 
     await act(() => fireEvent.click(updateSearchLink))
 
+    // Wait for navigation to complete and search params to update
+    await waitFor(() => {
+      expect(window.location.search).toBe('?page=2&filter=inactive')
+    })
+
     // Verify search was updated
     expect(window.location.pathname).toBe('/Dashboard/posts')
     expect(window.location.search).toBe('?page=2&filter=inactive')

packages/solid-router/tests/link.test.tsx

@@ -775,7 +775,12 @@ describe('Link', () => {
       '/posts?page=2&filter=inactive',
     )
 
-    fireEvent.click(updateSearchLink)
+    await fireEvent.click(updateSearchLink)
+
+    // Wait for navigation to complete and search params to update
+    await waitFor(() => {
+      expect(window.location.search).toBe('?page=2&filter=inactive')
+    })
 
     const updatedPage = await screen.findByTestId('current-page')
     const updatedFilter = await screen.findByTestId('current-filter')
@@ -888,7 +893,12 @@ describe('Link', () => {
       '/Dashboard/posts?page=2&filter=inactive',
     )
 
-    fireEvent.click(updateSearchLink)
+    await fireEvent.click(updateSearchLink)
+
+    // Wait for navigation to complete and search params to update
+    await waitFor(() => {
+      expect(window.location.search).toBe('?page=2&filter=inactive')
+    })
 
     await screen.findByTestId('current-page')
     // Verify search was updated