Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose ngxDropdown directive #9

Open
FrenchFriesFiesta opened this issue Sep 5, 2024 · 2 comments · May be fixed by #11
Open

Expose ngxDropdown directive #9

FrenchFriesFiesta opened this issue Sep 5, 2024 · 2 comments · May be fixed by #11

Comments

@FrenchFriesFiesta
Copy link

FrenchFriesFiesta commented Sep 5, 2024 •
edited
Loading

Hello! First off, thank you for maintaining the library!

The old version pre Angular 10 had exposed the ngxDropdown directive from DropdownTreeviewComponent, so you could programatically detect if it is closed, and also close it when needed.

Would it be possible to expose it on this as well?
@anuj9196
Copy link

Hi @FrenchFriesFiesta,

This is a clone of the parent repository with added support for the latest version of Angular. If you could provide a reference to the previous code sample for ngxDropdown or a link to the documentation in the previous library, I will try to add it as soon as possible.

Additionally, if you are interested in contributing, a pull request would be more helpful.

@FrenchFriesFiesta
Copy link
Author

FrenchFriesFiesta commented Sep 21, 2024 •
edited
Loading

Hi @anuj9196 !

Sure, here is a link to the original repo when it was still present, on line 24 This is the last time I could find that it was still present. In this commit it is already gone.

Here is the PR

@FrenchFriesFiesta FrenchFriesFiesta linked a pull request Sep 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Exposed dropdown directive from dropdown treeview component FrenchFriesFiesta/ngx-treeview2
2 participants
@anuj9196 @FrenchFriesFiesta