Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why Nov 1 is not coming as holiday. Its there in official holiday list. And it should be a holiday. #3

Open
krishnavelu opened this issue Mar 7, 2024 · 3 comments

Comments

@krishnavelu
Copy link

I'm able to get holidays now. Data looks good except 1.

This is the data I got for 2024 without weekends.

[datetime.datetime(2024, 1, 22, 0, 0),
datetime.datetime(2024, 1, 26, 0, 0),
datetime.datetime(2024, 3, 8, 0, 0),
datetime.datetime(2024, 3, 25, 0, 0),
datetime.datetime(2024, 3, 29, 0, 0),
datetime.datetime(2024, 4, 11, 0, 0),
datetime.datetime(2024, 4, 14, 0, 0),
datetime.datetime(2024, 4, 17, 0, 0),
datetime.datetime(2024, 4, 21, 0, 0),
datetime.datetime(2024, 5, 1, 0, 0),
datetime.datetime(2024, 6, 17, 0, 0),
datetime.datetime(2024, 7, 17, 0, 0),
datetime.datetime(2024, 8, 15, 0, 0),
datetime.datetime(2024, 9, 7, 0, 0),
datetime.datetime(2024, 10, 2, 0, 0),
datetime.datetime(2024, 10, 12, 0, 0),
datetime.datetime(2024, 11, 2, 0, 0),
datetime.datetime(2024, 11, 15, 0, 0),
datetime.datetime(2024, 12, 25, 0, 0)]

Why Nov 1 is not coming as holiday. Its there in official holiday list. And it should be a holiday.

image

@Tapanhaz
Copy link
Owner

Tapanhaz commented Mar 9, 2024

There will be a special trading session on that day on the occasion of diwali laxmi pujan (Muhurat trading.)

@krishnavelu
Copy link
Author

Yup, That will be accounted as holiday, so it should come in holiday list. Not as regular trading session.

@Tapanhaz
Copy link
Owner

Ok, I will make that optional in the next update. (maybe within this coming week.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants