Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running the bin script fails with "env: node\r: No such file or directory" #3

Closed
royra opened this issue Nov 19, 2019 · 5 comments
Closed
Labels
bug Something isn't working

Comments

@royra
Copy link

royra commented Nov 19, 2019

This is on mac and linux.

Looks like the ./bin/ts-cleaner.js file was published to npm with DOS CRLF newlines.

Running dos2unix on the file fixes the problem locally.

I think it needs to be republished with unix newlines.

@TarVK TarVK added the bug Something isn't working label Nov 19, 2019
@TarVK
Copy link
Owner

TarVK commented Nov 19, 2019

Hey @royra,
Thanks for informing me, I indeed have written and tested it only on windows. Is there any chance you could make a pull request, such that we're sure it works on mac/linux? I can try to correct it myself if you aren't able to, but I won't be able to verify whether it fixes the issue myself.

@royra
Copy link
Author

royra commented Nov 20, 2019

The code at GitHub has unix newlines, so I don't see how it's fixable with a PR.

Looks like it's a known NPM issue. Maybe you should publish a new version with fixed newlines?

@TarVK
Copy link
Owner

TarVK commented Nov 22, 2019

Aah alright, my bad.
I will look into it when I have time.

@TarVK
Copy link
Owner

TarVK commented Nov 23, 2019

I tried changing out the CRLF for LF, and published a new version to npm.
I haven't tested anything yet however. I would very much appreciate it if you could verify whether or not this fixed the issue. It also contains your fixes for the async problem.

@royra
Copy link
Author

royra commented Nov 26, 2019

Fixed in published version 1.0.4. Thanks!

@royra royra closed this as completed Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants