CLAP-453 Refactor: 댓글 history와 그 외의 history domain 생성 메서드 분리

joowojr · joowojr · commit cb2d8e3cb5c1 · 2025-02-18T21:56:58.000+09:00
#592
diff --git a/src/main/java/clap/server/adapter/outbound/persistense/entity/task/TaskHistoryEntity.java b/src/main/java/clap/server/adapter/outbound/persistense/entity/task/TaskHistoryEntity.java
@@ -1,14 +1,14 @@
 package clap.server.adapter.outbound.persistense.entity.task;
 
 import clap.server.adapter.outbound.persistense.entity.common.BaseTimeEntity;
+import clap.server.adapter.outbound.persistense.entity.member.MemberEntity;
 import clap.server.adapter.outbound.persistense.entity.task.constant.TaskHistoryType;
 import jakarta.persistence.*;
 import lombok.AccessLevel;
 import lombok.Builder;
 import lombok.Getter;
 import lombok.NoArgsConstructor;
 import lombok.experimental.SuperBuilder;
-import org.hibernate.annotations.SQLDelete;
 import org.hibernate.annotations.SQLRestriction;
 
 @Entity
@@ -30,6 +30,10 @@ public class TaskHistoryEntity extends BaseTimeEntity {
     @Embedded
     private TaskModificationInfo taskModificationInfo;
 
+    @ManyToOne(fetch = FetchType.LAZY)
+    @JoinColumn(name = "modified_member_id")
+    private MemberEntity modifiedMember;
+
     @OneToOne(fetch = FetchType.LAZY)
     @JoinColumn(name = "comment_id")
     private CommentEntity comment;
diff --git a/src/main/java/clap/server/adapter/outbound/persistense/entity/task/TaskModificationInfo.java b/src/main/java/clap/server/adapter/outbound/persistense/entity/task/TaskModificationInfo.java
@@ -1,7 +1,9 @@
 package clap.server.adapter.outbound.persistense.entity.task;
 
-import clap.server.adapter.outbound.persistense.entity.member.MemberEntity;
-import jakarta.persistence.*;
+import jakarta.persistence.Embeddable;
+import jakarta.persistence.FetchType;
+import jakarta.persistence.JoinColumn;
+import jakarta.persistence.ManyToOne;
 import lombok.AllArgsConstructor;
 import lombok.Builder;
 import lombok.Getter;
@@ -17,10 +19,6 @@ public class TaskModificationInfo {
     @JoinColumn(name = "task_id")
     private TaskEntity task;
 
-    @ManyToOne(fetch = FetchType.LAZY)
-    @JoinColumn(name = "modified_member_id")
-    private MemberEntity modifiedMember;
-
     @JoinColumn(name = "modified_status")
     private String modifiedStatus;
 }
diff --git a/src/main/java/clap/server/application/mapper/response/TaskHistoryResponseMapper.java b/src/main/java/clap/server/application/mapper/response/TaskHistoryResponseMapper.java
@@ -21,7 +21,7 @@ public static FindTaskHistoryResponse toFindTaskHistoryResponse(List<TaskHistory
                             switch (taskHistory.getType()) {
                                 case PROCESSOR_CHANGED, PROCESSOR_ASSIGNED -> new FindTaskHistoryResponse.Details(
                                         new FindTaskHistoryResponse.TaskDetails(
-                                                taskHistory.getTaskModificationInfo().getModifiedMember().getNickname()
+                                                taskHistory.getModifiedMember().getNickname()
                                         ),
                                         null,
                                         null
@@ -37,8 +37,8 @@ public static FindTaskHistoryResponse toFindTaskHistoryResponse(List<TaskHistory
                                         null,
                                         new FindTaskHistoryResponse.CommentDetails(
                                                 taskHistory.getComment().getCommentId(),
-                                                taskHistory.getComment().getMember().getNickname(),
-                                                taskHistory.getComment().getMember().getImageUrl(),
+                                                taskHistory.getModifiedMember().getNickname(),
+                                                taskHistory.getModifiedMember().getImageUrl(),
                                                 taskHistory.getComment().isModified(),
                                                 taskHistory.getComment().getContent()
                                         ),
@@ -49,8 +49,8 @@ public static FindTaskHistoryResponse toFindTaskHistoryResponse(List<TaskHistory
                                         null,
                                         new FindTaskHistoryResponse.CommentFileDetails(
                                                 taskHistory.getComment().getCommentId(),
-                                                taskHistory.getComment().getMember().getNickname(),
-                                                taskHistory.getComment().getMember().getImageUrl(),
+                                                taskHistory.getModifiedMember().getNickname(),
+                                                taskHistory.getModifiedMember().getImageUrl(),
                                                 taskHistory.getComment().getOriginalName(),
                                                 taskHistory.getComment().getFileUrl(),
                                                 taskHistory.getComment().getFileSize()
diff --git a/src/main/java/clap/server/application/service/history/FindTaskHistoriesService.java b/src/main/java/clap/server/application/service/history/FindTaskHistoriesService.java
@@ -7,10 +7,9 @@
 import clap.server.application.port.outbound.task.LoadTaskPort;
 import clap.server.application.port.outbound.taskhistory.LoadTaskHistoryPort;
 import clap.server.common.annotation.architecture.ApplicationService;
-import clap.server.domain.model.member.Member;
 import clap.server.domain.model.task.Task;
 import clap.server.domain.model.task.TaskHistory;
-import clap.server.exception.DomainException;
+import clap.server.exception.ApplicationException;
 import clap.server.exception.code.TaskErrorCode;
 import lombok.RequiredArgsConstructor;
 import org.springframework.transaction.annotation.Transactional;
@@ -29,7 +28,7 @@ public class FindTaskHistoriesService implements FindTaskHistoriesUsecase {
     public FindTaskHistoryResponse findTaskHistories(Long memberId, Long taskId) {
         memberService.findActiveMember(memberId);
         Task task = loadTaskPort.findById(taskId)
-                .orElseThrow(()-> new DomainException(TaskErrorCode.TASK_NOT_FOUND));
+                .orElseThrow(()-> new ApplicationException(TaskErrorCode.TASK_NOT_FOUND));
         List<TaskHistory> taskHistories = loadTaskHistoryPort.findAllTaskHistoriesByTaskId(task.getTaskId());
         return TaskHistoryResponseMapper.toFindTaskHistoryResponse(taskHistories);
     }
diff --git a/src/main/java/clap/server/application/service/history/PostCommentService.java b/src/main/java/clap/server/application/service/history/PostCommentService.java
@@ -9,17 +9,15 @@
 import clap.server.application.port.inbound.history.SaveCommentAttachmentUsecase;
 import clap.server.application.port.inbound.history.SaveCommentUsecase;
 import clap.server.application.port.outbound.s3.S3UploadPort;
-import clap.server.application.port.outbound.task.CommandAttachmentPort;
 import clap.server.application.port.outbound.task.CommandCommentPort;
 import clap.server.application.port.outbound.taskhistory.CommandTaskHistoryPort;
 import clap.server.application.service.webhook.SendNotificationService;
 import clap.server.common.annotation.architecture.ApplicationService;
+import clap.server.common.constants.FilePathConstants;
 import clap.server.domain.model.member.Member;
-import clap.server.domain.model.task.Attachment;
 import clap.server.domain.model.task.Comment;
 import clap.server.domain.model.task.Task;
 import clap.server.domain.model.task.TaskHistory;
-import clap.server.common.constants.FilePathConstants;
 import clap.server.domain.policy.task.TaskCommentPolicy;
 import lombok.RequiredArgsConstructor;
 import org.springframework.transaction.annotation.Transactional;
@@ -53,7 +51,7 @@ public void save(Long memberId, Long taskId, CreateCommentRequest request) {
         Comment comment = Comment.createComment(member, task, request.content(), null, null, null);
         Comment savedComment = commandCommentPort.saveComment(comment);
 
-        TaskHistory taskHistory = TaskHistory.createTaskHistory(TaskHistoryType.COMMENT, task, null, member, savedComment);
+        TaskHistory taskHistory = TaskHistory.createCommentTaskHistory(TaskHistoryType.COMMENT, member, savedComment);
         commandTaskHistoryPort.save(taskHistory);
 
         Member processor = task.getProcessor();
@@ -76,10 +74,10 @@ public void saveCommentAttachment(Long memberId, Long taskId, MultipartFile file
         String fileUrl = s3UploadPort.uploadSingleFile(FilePathConstants.TASK_COMMENT, file);
         String fileName = file.getOriginalFilename();
 
-        Comment comment = Comment.createComment(member, task, null, fileName, fileUrl,   formatFileSize(file.getSize()));
+        Comment comment = Comment.createComment(member, task, null, fileName, fileUrl, formatFileSize(file.getSize()));
         Comment savedComment = commandCommentPort.saveComment(comment);
 
-        TaskHistory taskHistory = TaskHistory.createTaskHistory(TaskHistoryType.COMMENT_FILE, null, null, member, savedComment);
+        TaskHistory taskHistory = TaskHistory.createCommentTaskHistory(TaskHistoryType.COMMENT_FILE, member, savedComment);
         commandTaskHistoryPort.save(taskHistory);
 
         Member processor = task.getProcessor();
@@ -93,14 +91,6 @@ public void saveCommentAttachment(Long memberId, Long taskId, MultipartFile file
 
     }
 
-    @Deprecated
-//    private String saveAttachment(MultipartFile file, Task task) {
-//        String fileUrl = s3UploadPort.uploadSingleFile(FilePathConstants.TASK_COMMENT, file);
-//        Attachment attachment = Attachment.createCommentAttachment(task, null, file.getOriginalFilename(), fileUrl, file.getSize());
-//        commandAttachmentPort.save(attachment);
-//        return file.getOriginalFilename();
-//    }
-
     private void publishNotification(Member receiver, Task task, String message, String commenterName) {
         boolean isManager = receiver.getMemberInfo().getRole() == MemberRole.ROLE_MANAGER;
         sendNotificationService.sendPushNotification(receiver, NotificationType.COMMENT, task, message, null, commenterName, isManager);
diff --git a/src/main/java/clap/server/application/service/task/ApprovalTaskService.java b/src/main/java/clap/server/application/service/task/ApprovalTaskService.java
@@ -59,7 +59,7 @@ public ApprovalTaskResponse approvalTaskByReviewer(Long reviewerId, Long taskId,
         updateProcessorTaskCountService.handleTaskStatusChange(processor, TaskStatus.REQUESTED, TaskStatus.IN_PROGRESS);
         task.approveTask(reviewer, processor, approvalTaskRequest.dueDate(), category, label);
 
-        TaskHistory taskHistory = TaskHistory.createTaskHistory(TaskHistoryType.PROCESSOR_ASSIGNED, task, null, processor, null);
+        TaskHistory taskHistory = TaskHistory.createTaskHistory(TaskHistoryType.PROCESSOR_ASSIGNED, task, null, processor);
         commandTaskHistoryPort.save(taskHistory);
 
         String processorName = processor.getNickname();
diff --git a/src/main/java/clap/server/application/service/task/TerminateTaskService.java b/src/main/java/clap/server/application/service/task/TerminateTaskService.java
@@ -37,7 +37,7 @@ public void terminateTask(Long memberId, Long taskId, String reason) {
         task.terminateTask();
         taskService.upsert(task);
 
-        TaskHistory taskHistory = TaskHistory.createTaskHistory(TaskHistoryType.TASK_TERMINATED, task, reason, null, null);
+        TaskHistory taskHistory = TaskHistory.createTaskHistory(TaskHistoryType.TASK_TERMINATED, task, reason, null);
         commandTaskHistoryPort.save(taskHistory);
 
         publishNotification(task.getRequester(), task, task.getTaskStatus().getDescription(), reason);
diff --git a/src/main/java/clap/server/application/service/task/UpdateTaskOrderAndStstusService.java b/src/main/java/clap/server/application/service/task/UpdateTaskOrderAndStstusService.java
@@ -82,7 +82,7 @@ public void updateTaskOrderAndStatus(Long processorId, UpdateTaskOrderRequest re
             updatedTask = updateNewTaskOrderAndStatus(targetStatus, targetTask, newOrder);
         }
 
-        TaskHistory taskHistory = TaskHistory.createTaskHistory(TaskHistoryType.STATUS_SWITCHED, updatedTask, targetStatus.getDescription(), null,null);
+        TaskHistory taskHistory = TaskHistory.createTaskHistory(TaskHistoryType.STATUS_SWITCHED, updatedTask, targetStatus.getDescription(), null);
         commandTaskHistoryPort.save(taskHistory);
         publishNotification(targetTask);
     }
diff --git a/src/main/java/clap/server/application/service/task/UpdateTaskService.java b/src/main/java/clap/server/application/service/task/UpdateTaskService.java
@@ -57,7 +57,7 @@ public void updateTaskStatus(Long memberId, Long taskId, TaskStatus targetTaskSt
             task.updateTaskStatus(targetTaskStatus);
             Task updatedTask = taskService.upsert(task);
 
-            saveTaskHistory(TaskHistory.createTaskHistory(TaskHistoryType.STATUS_SWITCHED, task, targetTaskStatus.getDescription(), null, null));
+            saveTaskHistory(TaskHistory.createTaskHistory(TaskHistoryType.STATUS_SWITCHED, task, targetTaskStatus.getDescription(), null));
 
             List<Member> receivers = List.of(task.getRequester());
             publishNotification(receivers, updatedTask, NotificationType.STATUS_SWITCHED, targetTaskStatus.getDescription());
@@ -79,7 +79,7 @@ public void updateTaskProcessor(Long taskId, Long memberId, UpdateTaskProcessorR
         task.updateProcessor(processor);
         Task updatedTask = taskService.upsert(task);
 
-        saveTaskHistory(TaskHistory.createTaskHistory(TaskHistoryType.PROCESSOR_CHANGED, task, null, processor, null));
+        saveTaskHistory(TaskHistory.createTaskHistory(TaskHistoryType.PROCESSOR_CHANGED, task, null, processor));
 
         List<Member> receivers = List.of(updatedTask.getRequester());
         publishNotification(receivers, updatedTask, NotificationType.PROCESSOR_CHANGED, processor.getNickname());
diff --git a/src/main/java/clap/server/domain/model/task/TaskHistory.java b/src/main/java/clap/server/domain/model/task/TaskHistory.java
@@ -1,10 +1,8 @@
 package clap.server.domain.model.task;
 
 import clap.server.adapter.outbound.persistense.entity.task.constant.TaskHistoryType;
-
 import clap.server.domain.model.common.BaseTime;
 import clap.server.domain.model.member.Member;
-
 import lombok.*;
 import lombok.experimental.SuperBuilder;
 
@@ -15,6 +13,7 @@ public class TaskHistory extends BaseTime {
     private Long taskHistoryId;
     private TaskHistoryType type;
     private TaskModificationInfo taskModificationInfo;
+    private Member modifiedMember;
     private Comment comment;
 
     @Getter
@@ -23,20 +22,33 @@ public class TaskHistory extends BaseTime {
     @NoArgsConstructor(access = AccessLevel.PROTECTED)
     public static class TaskModificationInfo {
         private Task task;
-        private Member modifiedMember;
         private String modifiedStatus;
     }
 
-    public static TaskHistory createTaskHistory(TaskHistoryType type, Task task, String statusDescription, Member member, Comment comment) {
+    public static TaskHistory createTaskHistory(TaskHistoryType type, Task task, String statusDescription, Member member) {
         return TaskHistory.builder()
                 .type(type)
+                .modifiedMember(member)
                 .taskModificationInfo(
                         TaskModificationInfo.builder()
                                 .task(task)
-                                .modifiedMember(member)
                                 .modifiedStatus(statusDescription)
                                 .build()
                 )
+                .comment(null)
+                .build();
+    }
+
+    public static TaskHistory createCommentTaskHistory(TaskHistoryType type, Member member, Comment comment) {
+        return TaskHistory.builder()
+                .type(type)
+                .modifiedMember(member)
+                .taskModificationInfo(
+                        TaskModificationInfo.builder()
+                                .task(null)
+                                .modifiedStatus(null)
+                                .build()
+                )
                 .comment(comment)
                 .build();
     }

Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ public void updateTaskOrderAndStatus(Long processorId, UpdateTaskOrderRequest re`
`82`	`82`	`updatedTask = updateNewTaskOrderAndStatus(targetStatus, targetTask, newOrder);`
`83`	`83`	`}`
`84`	`84`
`85`		`- TaskHistory taskHistory = TaskHistory.createTaskHistory(TaskHistoryType.STATUS_SWITCHED, updatedTask, targetStatus.getDescription(), null,null);`
	`85`	`+ TaskHistory taskHistory = TaskHistory.createTaskHistory(TaskHistoryType.STATUS_SWITCHED, updatedTask, targetStatus.getDescription(), null);`
`86`	`86`	`commandTaskHistoryPort.save(taskHistory);`
`87`	`87`	`publishNotification(targetTask);`
`88`	`88`	`}`