Skip to content

Commit fced377

Browse files
authored
2020 May 30 Breaking Changes Update (qmk#9215)
* Branch point for 2020 May 30 Breaking Change * Migrate `ACTION_LAYER_TOGGLE` to `TG()` (qmk#8954) * Migrate `ACTION_MODS_ONESHOT` to `OSM()` (qmk#8957) * Migrate `ACTION_DEFAULT_LAYER_SET` to `DF()` (qmk#8958) * Migrate `ACTION_LAYER_MODS` to `LM()` (qmk#8959) * Migrate `ACTION_MODS_TAP_KEY` to `MT()` (qmk#8968) * Convert V-USB usbdrv to a submodule (qmk#8321) * Unify Tap Hold functions and documentation (qmk#8348) * Changing board names to prevent confusion (qmk#8412) * Move the Keyboardio Model01 to a keyboardio/ subdir (qmk#8499) * Move spaceman keyboards (qmk#8830) * Migrate miscellaneous `fn_actions` entries (qmk#8977) * Migrate `ACTION_MODS_KEY` to chained mod keycodes (qmk#8979) * Organizing my keyboards (plaid, tartan, ergoinu) (qmk#8537) * Refactor Lily58 to use split_common (qmk#6260) * Refactor zinc to use split_common (qmk#7114) * Add a message if bin/qmk doesn't work (qmk#9000) * Fix conflicting types for 'tfp_printf' (qmk#8269) * Fixed RGB_DISABLE_AFTER_TIMEOUT to be seconds based & small internals cleanup (qmk#6480) * Refactor and updates to TKC1800 code (qmk#8472) * Switch to qmk forks for everything (qmk#9019) * audio refactor: replace deprecated PLAY_NOTE_ARRAY (qmk#8484) * Audio enable corrections (2/3) (qmk#8903) * Split HHKB to ANSI and JP layouts and Add VIA support for each (qmk#8582) * Audio enable corrections (Part 4) (qmk#8974) * Fix typo from PR7114 (qmk#9171) * Augment future branch Changelogs (qmk#8978) * Revert "Branch point for 2020 May 30 Breaking Change"
1 parent 7b8a013 commit fced377

File tree

460 files changed

+2627
-12712
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

460 files changed

+2627
-12712
lines changed

.gitmodules

+7-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,13 @@
1212
branch = master
1313
[submodule "lib/googletest"]
1414
path = lib/googletest
15-
url = https://github.com/google/googletest
15+
url = https://github.com/qmk/googletest
1616
[submodule "lib/lufa"]
1717
path = lib/lufa
1818
url = https://github.com/qmk/lufa
19+
[submodule "lib/vusb"]
20+
path = lib/vusb
21+
url = https://github.com/qmk/v-usb
22+
[submodule "lib/printf"]
23+
path = lib/printf
24+
url = https://github.com/qmk/printf

Makefile

+4-2
Original file line numberDiff line numberDiff line change
@@ -562,14 +562,16 @@ endef
562562
%:
563563
# Check if we have the CMP tool installed
564564
cmp $(ROOT_DIR)/Makefile $(ROOT_DIR)/Makefile >/dev/null 2>&1; if [ $$? -gt 0 ]; then printf "$(MSG_NO_CMP)"; exit 1; fi;
565-
# Ensure that python3 is installed. This check can be removed after python is used in more places.
566-
if ! python3 --version 1> /dev/null 2>&1; then printf "$(MSG_PYTHON_MISSING)"; fi
565+
# Ensure that bin/qmk works. This will be a failing check after the next develop merge on 2020 Aug 29.
566+
if ! bin/qmk hello 1> /dev/null 2>&1; then printf "$(MSG_PYTHON_MISSING)"; fi
567567
# Check if the submodules are dirty, and display a warning if they are
568568
ifndef SKIP_GIT
569569
if [ ! -e lib/chibios ]; then git submodule sync lib/chibios && git submodule update --depth 50 --init lib/chibios; fi
570570
if [ ! -e lib/chibios-contrib ]; then git submodule sync lib/chibios-contrib && git submodule update --depth 50 --init lib/chibios-contrib; fi
571571
if [ ! -e lib/ugfx ]; then git submodule sync lib/ugfx && git submodule update --depth 50 --init lib/ugfx; fi
572572
if [ ! -e lib/lufa ]; then git submodule sync lib/lufa && git submodule update --depth 50 --init lib/lufa; fi
573+
if [ ! -e lib/vusb ]; then git submodule sync lib/vusb && git submodule update --depth 50 --init lib/vusb; fi
574+
if [ ! -e lib/printf ]; then git submodule sync lib/printf && git submodule update --depth 50 --init lib/printf; fi
573575
git submodule status --recursive 2>/dev/null | \
574576
while IFS= read -r x; do \
575577
case "$$x" in \

docs/ChangeLog/20200530.md

+239
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,239 @@
1+
# QMK Breaking Change - 2020 May 30 Changelog
2+
3+
Four times a year QMK runs a process for merging Breaking Changes. A Breaking Change is any change which modifies how QMK behaves in a way that is incompatible or potentially dangerous. We limit these changes to 4 times per year so that users can have confidence that updating their QMK tree will not break their keymaps.
4+
5+
The list of changes follows.
6+
7+
8+
## Core Changes
9+
10+
### Converting V-USB usbdrv to a submodule
11+
12+
[#8321](https://github.com/qmk/qmk_firmware/pull/8321) and [qmk_compiler#62](https://github.com/qmk/qmk_compiler/pull/62).
13+
14+
These PRs move the V-USB driver code out of the qmk_firmware repository and into a submodule pointed at https://github.com/obdev/v-usb. This will make it easier to update the codebase if needed, while applying any potential QMK-specific modifications by forking it to the QMK GitHub organization.
15+
16+
### Unify Tap Hold functions and documentation
17+
18+
[#8348](https://github.com/qmk/qmk_firmware/pull/8348)
19+
20+
Updates all of the per key tap-hold functions to pass the `keyrecord_t` structure, and include documentation changes.
21+
22+
Any remaining versions or code outside of the main repo will need to be converted:
23+
| Old function | New Function |
24+
|------------------------------------------------------|---------------------------------------------------------------------------|
25+
|`uint16_t get_tapping_term(uint16_t keycode)` |`uint16_t get_tapping_term(uint16_t keycode, keyrecord_t *record)` |
26+
|`bool get_ignore_mod_tap_interrupt(uint16_t keycode)` |`bool get_ignore_mod_tap_interrupt(uint16_t keycode, keyrecord_t *record)` |
27+
28+
### Python Required In The Build Process
29+
30+
[#9000](https://github.com/qmk/qmk_firmware/pull/9000)
31+
32+
This is the last release of QMK that will work without having Python 3.6 (or later) installed. If your environment is not fully setup you will get a warning instructing you to set it up.
33+
34+
After the next breaking change you will not be able to build if `bin/qmk hello` does not work.
35+
36+
### Upgrade from tinyprintf to mpaland/printf
37+
38+
[#8269](https://github.com/qmk/qmk_firmware/pull/8269)
39+
40+
- Provides debug functionality on ChibiOS/ARM that is more compliant than previous integrations.
41+
- Less maintenence, fewer QMK customisations, and allows QMK to sidestep previous compile and runtime issues.
42+
- A `make git-submodule` may be required after pulling the latest QMK Firmware code to update to the new dependency.
43+
44+
### Fixed RGB_DISABLE_AFTER_TIMEOUT to be seconds based & small internals cleanup
45+
46+
[#6480](https://github.com/qmk/qmk_firmware/pull/6480)
47+
48+
- Changes `RGB_DISABLE_AFTER_TIMEOUT` to be based on milliseconds instead of ticks.
49+
- Includes a code cleanup, resulting in a savings of 100 bytes, depending on features used.
50+
- Fixed issues with timeouts / suspending at the wrong time not turning off all LEDs in some cases.
51+
52+
The `RGB_DISABLE_AFTER_TIMEOUT` definition is now deprecated, and has been superseded by `RGB_DISABLE_TIMEOUT`. To use the new definition, rename `RGB_DISABLE_AFTER_TIMEOUT` to `RGB_DISABLE_TIMEOUT` in your `config.h` file, and multiply the value set by 1200.
53+
54+
Before: `#define RGB_DISABLE_AFTER_TIMEOUT 100`
55+
After: `#define RGB_DISABLE_TIMEOUT 120000`
56+
57+
### Switch to qmk forks for everything
58+
59+
[#9019](https://github.com/qmk/qmk_firmware/pull/9019)
60+
61+
Fork all QMK submodules to protect against upstream repositories disappearing.
62+
63+
### code cleanup regarding deprecated macro PLAY_NOTE_ARRAY by replacing it with PLAY_SONG
64+
65+
[#8484](https://github.com/qmk/qmk_firmware/pull/8484)
66+
67+
Removes the deprecated `PLAY_NOTE_ARRAY` macro. References to it are replaced with `PLAY_SONG`, which references the same function.
68+
69+
### fixing wrong configuration of AUDIO feature
70+
71+
[#8903](https://github.com/qmk/qmk_firmware/pull/8903) and [#8974](https://github.com/qmk/qmk_firmware/pull/8974)
72+
73+
`audio_avr.c` does not default to any pin; there has to be a #define XX_AUDIO in config.h at some level for Audio to actually work. Otherwise, the Audio code ends up cluttering the firmware, possibly breaking builds because the maximum allowed firmware size is exceeded.
74+
75+
These changes fix this by disabling Audio on keyboards that have the feature misconfigured, and therefore non-functional.
76+
77+
Also, add a compile-time error to alert the user to a missing pin-configuration (on AVR boards) when `AUDIO_ENABLE = yes` is set.
78+
79+
80+
## Keyboard Refactors
81+
82+
### Migrating Lily58 to use split_common
83+
84+
[#6260](https://github.com/qmk/qmk_firmware/pull/6260)
85+
86+
Modifies the default firmware for Lily58 to use the `split_common` library, instead of including and depending on its own set of libraries for the following functionality:
87+
88+
- SSD1306 display
89+
- i2c for OLED
90+
- Serial Communication
91+
92+
This allows current lily58 firmware to advance with updates to the `split_common` library, which is shared with many other split keyboards.
93+
94+
#### To migrate existing Lily58 firmware:
95+
96+
[Changes to `config.h`](https://github.com/qmk/qmk_firmware/pull/6260/files#diff-445ac369c8717dcd6fc6fc3630836fc1):
97+
- Remove `#define SSD1306OLED` from config.h
98+
99+
100+
[Changes to `keymap.c`](https://github.com/qmk/qmk_firmware/pull/6260/files#diff-20943ea59856e9bdf3d99ecb2eee40b7):
101+
- Find/Replace each instance of `#ifdef SSD1306OLED` with `#ifdef OLED_DRIVER_ENABLE`
102+
- The following changes are for compatibility with the OLED driver. If you don't use the OLED driver you may safely delete [this section](https://github.com/qmk/qmk_firmware/blob/e6b9980bd45c186f7360df68c24b6e05a80c10dc/keyboards/lily58/keymaps/default/keymap.c#L144-L190)
103+
- Alternatively, if you did not change the OLED code from that in `default`, you may find it easier to simply copy the [relevant section](https://github.com/qmk/qmk_firmware/blob/4ac310668501ae6786c711ecc8f01f62ddaa1c0b/keyboards/lily58/keymaps/default/keymap.c#L138-L172). Otherwise, the changes you need to make are as follows (sample change [here](https://github.com/qmk/qmk_firmware/pull/6260/files#diff-20943ea59856e9bdf3d99ecb2eee40b7R138-R173))
104+
- [Remove](https://github.com/qmk/qmk_firmware/pull/6260/files#diff-20943ea59856e9bdf3d99ecb2eee40b7L138-L141) the block
105+
```c
106+
#ifdef SSD1306OLED
107+
iota_gfx_init(!has_usb()); // turns on the display
108+
#endif
109+
```
110+
- Within the block bounded by `#ifdef OLED_DRIVER_ENABLE` and `#endif // OLED_DRIVER_ENABLE`, add the following block to ensure that your two OLEDs are rotated correctly across the left and right sides:
111+
```c
112+
oled_rotation_t oled_init_user(oled_rotation_t rotation) {
113+
if (!is_keyboard_master())
114+
return OLED_ROTATION_180; // flips the display 180 degrees if offhand
115+
return rotation;
116+
}
117+
```
118+
- Remove the functions `matrix_scan_user`, `matrix_update` and `iota_gfx_task_user`
119+
- Find/Replace `matrix_render_user(struct CharacterMatrix *matrix)` with `iota_gfx_task_user(void)`
120+
- Find/Replace `is_master` with `is_keyboard_master()`
121+
- For each instance of `matrix_write_ln(matrix, display_fn())`, rewrite it as `oled_write_ln(read_layer_state(), false);`
122+
- For each instance of `matrix_write(matrix, read_logo());`, replace with `oled_write(read_logo(), false);`
123+
124+
### Refactor zinc to use split_common
125+
126+
[#7114](https://github.com/qmk/qmk_firmware/pull/7114) and [#9171](https://github.com/qmk/qmk_firmware/pull/9171)
127+
128+
* Refactor to use split_common and remove split codes under the zinc/revx/
129+
* Add - backlight RGB LED and/or underglow RGB LED option
130+
* Add - continuous RGB animations feature (between L and R halves)
131+
* Fix - keymap files to adapt to changes
132+
* all authors of keymaps confirmed this PR
133+
* Update - documents and rules.mk
134+
135+
### Refactor of TKC1800 to use common OLED code
136+
137+
[#8472](https://github.com/qmk/qmk_firmware/pull/8472)
138+
139+
Modifies the default firmware for TKC1800 to use the in-built I2C and OLED drivers, instead of including and depending on its own set of libraries for the following functionality:
140+
141+
- SSD1306 display
142+
- i2c for OLED
143+
144+
This allows current TKC1800 firmware to advance with updates to those drivers, which are shared with other keyboards.
145+
146+
#### To migrate existing TKC1800 firmware:
147+
148+
[Changes to `config.h`](https://github.com/qmk/qmk_firmware/pull/8472/files#diff-d10b26e676b4a55cbb00d71955116526):
149+
- Remove `#define SSD1306OLED` from config.h
150+
151+
[Changes to `tkc1800.c`](https://github.com/qmk/qmk_firmware/pull/8472/files#diff-3b35bd30abe89c8110717c6972cd2cc5):
152+
- Add the following to avoid debug errors on HID_listen if the screen is not present
153+
```c
154+
void keyboard_pre_init_kb(void) {
155+
setPinInputHigh(D0);
156+
setPinInputHigh(D1);
157+
158+
keyboard_pre_init_user();
159+
}
160+
```
161+
162+
[Changes to `keymap.c`](https://github.com/qmk/qmk_firmware/pull/8472/files#diff-05a2a344ce27e4d045fe68520ccd4771):
163+
- Find/Replace each instance of `#ifdef SSD1306OLED` with `#ifdef OLED_DRIVER_ENABLE`
164+
- The following changes are for compatibility with the OLED driver. If you don't use the OLED driver you may safely delete [this section](https://github.com/qmk/qmk_firmware/blob/e6b9980bd45c186f7360df68c24b6e05a80c10dc/keyboards/lily58/keymaps/default/keymap.c#L144-L190)
165+
- [Remove](https://github.com/qmk/qmk_firmware/pull/6260/files#diff-20943ea59856e9bdf3d99ecb2eee40b7L91-L158) the block
166+
```c
167+
#ifdef SSD1306OLED
168+
iota_gfx_init(!has_usb()); // turns on the display
169+
#endif
170+
```
171+
- Within the block bounded by `#ifdef OLED_DRIVER_ENABLE` and `#endif // OLED_DRIVER_ENABLE`, add the following block to ensure that your two OLEDs are rotated correctly across the left and right sides:
172+
```c
173+
oled_rotation_t oled_init_user(oled_rotation_t rotation) {
174+
if (!is_keyboard_master())
175+
return OLED_ROTATION_180; // flips the display 180 degrees if offhand
176+
return rotation;
177+
}
178+
```
179+
- Remove the function `iota_gfx_task_user`
180+
181+
### Split HHKB to ANSI and JP layouts and Add VIA support for each
182+
183+
[#8582](https://github.com/qmk/qmk_firmware/pull/8582)
184+
185+
- Splits the HHKB codebase into two separate folders `keyboards/hhkb/ansi` and `keyboards/hhkb/jp`.
186+
- Adds VIA Configurator support for both versions.
187+
188+
#### Migrating existing HHKB keymaps
189+
190+
- Remove any checks for the `HHKB_JP` definition
191+
- All checks for this definition have been removed, and each version uses the source that is appropriate to that version.
192+
- Move the directory for your keymap into the appropriate `keymaps` directory
193+
- `keyboards/hhkb/ansi/keymaps/` for ANSI HHKBs
194+
- `keyboards/hhkb/jp/keymaps/` for HHKB JPs
195+
- Compile with the new keyboard names
196+
- This PR changes the compilation instructions for the HHKB Alternate Controller. To compile firmware for this controller moving forward, use:
197+
- `make hhkb/ansi` for ANSI-layout HHKBs
198+
- `make hhkb/jp` for HHKB JP keyboards
199+
200+
201+
## Keyboard Moves
202+
203+
- [#8412](https://github.com/qmk/qmk_firmware/pull/8412 "Changing board names to prevent confusion") by blindassassin111
204+
- [#8499](https://github.com/qmk/qmk_firmware/pull/8499 "Move the Keyboardio Model01 to a keyboardio/ subdir") by algernon
205+
- [#8830](https://github.com/qmk/qmk_firmware/pull/8830 "Move spaceman keyboards") by Spaceman (formerly known as Rionlion100)
206+
- [#8537](https://github.com/qmk/qmk_firmware/pull/8537 "Organizing my keyboards (plaid, tartan, ergoinu)") by hsgw
207+
208+
Keyboards by Keyboardio, Spaceman, and hsgw move to vendor folders, while PCBs designed by blindassassin111 are renamed.
209+
210+
Old Name | New Name
211+
:----------------- | :-----------------
212+
2_milk | spaceman/2_milk
213+
at101_blackheart | at101_bh
214+
ergoinu | dm9records/ergoinu
215+
model01 | keyboardio/model01
216+
omnikey_blackheart | omnikey_bh
217+
pancake | spaceman/pancake
218+
plaid | dm9records/plaid
219+
tartan | dm9records/tartan
220+
z150_blackheart | z150_bh
221+
222+
If you own one of these PCBs, please use the new names to compile your firmware moving forward.
223+
224+
225+
## Keycode Migration PRs
226+
227+
[#8954](https://github.com/qmk/qmk_firmware/pull/8954 "Migrate `ACTION_LAYER_TOGGLE` to `TG()`"), [#8957](https://github.com/qmk/qmk_firmware/pull/8957 "Migrate `ACTION_MODS_ONESHOT` to `OSM()`"), [#8958](https://github.com/qmk/qmk_firmware/pull/8958 "Migrate `ACTION_DEFAULT_LAYER_SET` to `DF()`"), [#8959](https://github.com/qmk/qmk_firmware/pull/8959 "Migrate `ACTION_LAYER_MODS` to `LM()`"), [#8968](https://github.com/qmk/qmk_firmware/pull/8968 "Migrate `ACTION_MODS_TAP_KEY` to `MT()`"), [#8977](https://github.com/qmk/qmk_firmware/pull/8977 "Migrate miscellaneous `fn_actions` entries"), and [#8979](https://github.com/qmk/qmk_firmware/pull/8979 "Migrate `ACTION_MODS_KEY` to chained mod keycodes")
228+
229+
Authored by fauxpark, these pull requests remove references to deprecated TMK macros that have been superseded by native QMK keycodes.
230+
231+
Old `fn_actions` action | New QMK keycode
232+
:---------------------- | :--------------
233+
`ACTION_DEFAULT_LAYER_SET(layer)` | `DF(layer)`
234+
`ACTION_LAYER_MODS(layer, mod)` | `LM(layer, mod)`
235+
`ACTION_LAYER_ONESHOT(mod)` | `OSL(mod)`
236+
`ACTION_LAYER_TOGGLE(layer)` | `TG(layer)`
237+
`ACTION_MODS_ONESHOT(mod)` | `OSM(mod)`
238+
`ACTION_MODS_TAP_KEY(mod, kc)` | `MT(mod, kc)`
239+
`ACTION_MODS_KEY(mod, kc)`<br>e.g. `ACTION_MODS_KEY(MOD_LCTL, KC_0)` | `MOD(kc)`<br>e.g. `LCTL(KC_0)`

docs/_summary.md

+1
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@
115115
* [Overview](breaking_changes.md)
116116
* [My Pull Request Was Flagged](breaking_changes_instructions.md)
117117
* History
118+
* [2020 May 30](ChangeLog/20200530.md)
118119
* [2020 Feb 29](ChangeLog/20200229.md)
119120
* [2019 Aug 30](ChangeLog/20190830.md)
120121

docs/breaking_changes.md

+23-22
Original file line numberDiff line numberDiff line change
@@ -6,27 +6,28 @@ The breaking change period is when we will merge PR's that change QMK in dangero
66

77
## What has been included in past Breaking Changes?
88

9+
* [2020 May 30](ChangeLog/20200530.md)
910
* [2020 Feb 29](ChangeLog/20200229.md)
1011
* [2019 Aug 30](ChangeLog/20190830.md)
1112

1213
## When is the next Breaking Change?
1314

14-
The next Breaking Change is scheduled for May 30, 2020.
15+
The next Breaking Change is scheduled for Aug 29, 2020.
1516

1617
### Important Dates
1718

18-
* [x] 2020 Feb 29 - `future` is created. It will be rebased weekly.
19-
* [ ] 2020 May 2 - `future` closed to new PR's.
20-
* [ ] 2020 May 2 - Call for testers.
21-
* [ ] 2020 May 28 - `master` is locked, no PR's merged.
22-
* [ ] 2020 May 30 - Merge `future` to `master`.
23-
* [ ] 2020 May 30 - `master` is unlocked. PR's can be merged again.
19+
* [x] 2020 May 30 - `develop` is created. It will be rebased weekly.
20+
* [ ] 2020 Aug 1 - `develop` closed to new PR's.
21+
* [ ] 2020 Aug 1 - Call for testers.
22+
* [ ] 2020 Aug 27 - `master` is locked, no PR's merged.
23+
* [ ] 2020 Aug 29 - Merge `develop` to `master`.
24+
* [ ] 2020 Aug 29 - `master` is unlocked. PR's can be merged again.
2425

2526
## What changes will be included?
2627

27-
To see a list of breaking change candidates you can look at the [`breaking_change` label](https://github.com/qmk/qmk_firmware/pulls?q=is%3Aopen+label%3Abreaking_change+is%3Apr). New changes might be added between now and when `future` is closed, and a PR with that label applied is not guaranteed to be merged.
28+
To see a list of breaking change candidates you can look at the [`breaking_change` label](https://github.com/qmk/qmk_firmware/pulls?q=is%3Aopen+label%3Abreaking_change+is%3Apr). New changes might be added between now and when `develop` is closed, and a PR with that label applied is not guaranteed to be merged.
2829

29-
If you want your breaking change to be included in this round you need to create a PR with the `breaking_change` label and have it accepted before `future` closes. After `future` closes no new breaking changes will be accepted.
30+
If you want your breaking change to be included in this round you need to create a PR with the `breaking_change` label and have it accepted before `develop` closes. After `develop` closes no new breaking changes will be accepted.
3031

3132
Criteria for acceptance:
3233

@@ -37,41 +38,41 @@ Criteria for acceptance:
3738

3839
This section documents various processes we use when running the Breaking Changes process.
3940

40-
## Rebase `future` from `master`
41+
## Rebase `develop` from `master`
4142

42-
This is run every Friday while `future` is open.
43+
This is run every Friday while `develop` is open.
4344

4445
Process:
4546

4647
```
4748
cd qmk_firmware
4849
git checkout master
4950
git pull --ff-only
50-
git checkout future
51+
git checkout develop
5152
git rebase master
5253
git push --force
5354
```
5455

55-
## Creating the `future` branch
56+
## Creating the `develop` branch
5657

57-
This happens immediately after the previous `future` branch is merged.
58+
This happens immediately after the previous `develop` branch is merged.
5859

5960
* `qmk_firmware` git commands
6061
* [ ] `git checkout master`
6162
* [ ] `git pull --ff-only`
62-
* [ ] `git checkout -b future`
63+
* [ ] `git checkout -b develop`
6364
* [ ] Edit `readme.md`
6465
* [ ] Add a big notice at the top that this is a testing branch.
6566
* [ ] Include a link to this document
6667
* [ ] `git commit -m 'Branch point for <DATE> Breaking Change'`
6768
* [ ] `git tag breakpoint_<YYYY>_<MM>_<DD>`
6869
* [ ] `git tag <next_version>` # Prevent the breakpoint tag from confusing version incrementing
69-
* [ ] `git push origin future`
70+
* [ ] `git push origin develop`
7071
* [ ] `git push --tags`
7172

7273
## 4 Weeks Before Merge
7374

74-
* `future` is now closed to new PR's, only fixes for current PR's may be merged
75+
* `develop` is now closed to new PR's, only fixes for current PR's may be merged
7576
* Post call for testers
7677
* [ ] Discord
7778
* [ ] GitHub PR
@@ -94,15 +95,15 @@ This happens immediately after the previous `future` branch is merged.
9495
## Day Of Merge
9596

9697
* `qmk_firmware` git commands
97-
* [ ] `git checkout future`
98+
* [ ] `git checkout develop`
9899
* [ ] `git pull --ff-only`
99100
* [ ] `git rebase origin/master`
100101
* [ ] Edit `readme.md`
101-
* [ ] Remove the notes about `future`
102+
* [ ] Remove the notes about `develop`
102103
* [ ] Roll up the ChangeLog into one file.
103104
* [ ] `git commit -m 'Merge point for <DATE> Breaking Change'`
104-
* [ ] `git push origin future`
105+
* [ ] `git push origin develop`
105106
* GitHub Actions
106-
* [ ] Create a PR for `future`
107+
* [ ] Create a PR for `develop`
107108
* [ ] Make sure travis comes back clean
108-
* [ ] Merge `future` PR
109+
* [ ] Merge `develop` PR

0 commit comments

Comments
 (0)