-
Notifications
You must be signed in to change notification settings - Fork 19
how to use cargo in the benchmarks game #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I talked to @alexcrichton on IRC, and he seems to think the 32 bit problem is an LTO related bug. Perhaps we could open a new thread in the benchmark game forum and ask the maintainer to not use LTO? (I guess this might be a question that must be answered for all Rust benchmarks.) |
@TeXitoi The maintainer has stated that we can selectively disable LTO on certain benchmarks. I'm in favor of disabling it for |
I'm OK to disable lto everywhere. I'll look for the cargo installation with dependencies. Sorry I'm quite busy now, I don't know when I'll have time to do that. |
I think I have it working now. I'll push a PR shortly. |
closed by #13 |
I just went through the process of getting the regex benchmark updated (because it recently got a lot of optimizations), and this required Cargo because
regex
now has four total dependencies:regex-syntax
,aho-corasick
,memchr
andlibc
.It was a little tricky to get working because the maintainer still needs to be able to run
rustc
on the submitted benchmark.Here is the thread: https://alioth.debian.org/tracker/index.php?func=detail&aid=315089&group_id=100815&atid=413122
The approach we finally settled on was to set up a blank Cargo project with
regex
as a dependency,cargo build --release
it, and then userustc
with-L
with the./target/release/deps
directory:This does fail on 32 bit unfortunately, as can be seen here at the bottom of the list: http://benchmarksgame.alioth.debian.org/u32/performance.php?test=regexdna I filed a bug with rustc: rust-lang/rust#26541
I'm hoping this info is useful enough so that we can:
regex
benchmark can be maintained here.The text was updated successfully, but these errors were encountered: