Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add different panes to preferences #2968

Closed
EmmanuelMess opened this issue Oct 30, 2021 · 15 comments · Fixed by #3140
Closed

Add different panes to preferences #2968

EmmanuelMess opened this issue Oct 30, 2021 · 15 comments · Fixed by #3140
Assignees
Labels
Area-UIUX Related to user interface/experience (e.g. dialogs, notifications). Bounty Issue-Easy (good first issue) Beginners welcome! Issues with relative low difficulty. Issue-Feature A feature request or improvement. Issue-Task (low) This isn't a bug, but should be dealt with.

Comments

@EmmanuelMess
Copy link
Member

EmmanuelMess commented Oct 30, 2021

Add different panes to preferences activity.


This now has a bounty, here, bounty expires in one month from 2022-01-13, if you have been working, please alert us so that we can extend it.

Please claim after a PR fixing this issue is accepted.
Remember that you can also back the issue adding to the bounty!

@EmmanuelMess EmmanuelMess added Area-UIUX Related to user interface/experience (e.g. dialogs, notifications). Issue-Easy (good first issue) Beginners welcome! Issues with relative low difficulty. Issue-Feature A feature request or improvement. Issue-Task (low) This isn't a bug, but should be dealt with. labels Oct 30, 2021
@aniket691
Copy link

Can u elaborate and assign me. I want to take this issue.

@VishnuSanal
Copy link
Member

Can u elaborate

@EmmanuelMess

@EmmanuelMess
Copy link
Member Author

EmmanuelMess commented Nov 24, 2021

Something like this:
imagen

This issue requires a discussion on the design first. Use this link as guide https://developer.android.com/guide/topics/ui/settings/organize-your-settings and the design of Telegram's preferences.

@EmmanuelMess
Copy link
Member Author

@aniket691 this issue now has a bounty.

@EmmanuelMess EmmanuelMess pinned this issue Jan 14, 2022
@EmmanuelMess EmmanuelMess unpinned this issue Jan 14, 2022
@EmmanuelMess EmmanuelMess pinned this issue Jan 20, 2022
@nicbn
Copy link
Contributor

nicbn commented Jan 20, 2022

I'm working on this

@EmmanuelMess EmmanuelMess assigned nicbn and unassigned aniket691 Jan 20, 2022
@EmmanuelMess
Copy link
Member Author

Please provide a small graph of how it will be layout so that the design can be approved.

@nicbn
Copy link
Contributor

nicbn commented Jan 20, 2022

image

  • Appearance
    • Theme
    • Color (inline the current page)
    • Use circular icons
    • Show dividers
    • Show headers
    • Automatically hide toolbar
    • Number of columns in grid view
    • Enable marquee effect for file names
  • Interface
    • Sidebar
    • All other show/hide options
    • Back navigation
    • Drag and drop preference
    • Advanced:
      • Show permissions
  • Behavior
    • Remember paths
    • Clear cache
    • Advanced search
    • Custom paths
    • Open as new task
    • Archive folder
    • Advanced:
      • Use legacy for root
      • Root explorer
  • Security
    • Master password
    • Fingerprint

WDYT?

@EmmanuelMess
Copy link
Member Author

I like it. @VishalNehra @TranceLove @VishnuSanal ?

@EmmanuelMess
Copy link
Member Author

@nicbn are the icons what the material design guidelines recommends?

@nicbn
Copy link
Contributor

nicbn commented Jan 20, 2022

I couldn't find anything about icons on settings at the material design guidelines. I simply used icons I found appropriate for each category and added a backdrop as the Android system settings does.

@EmmanuelMess
Copy link
Member Author

EmmanuelMess commented Jan 20, 2022

I couldn't find anything about icons on settings at the material design guidelines. I simply used icons I found appropriate for each category and added a backdrop as the Android system settings does.

It looks like Android 9 settings has that kind of icons, so its ok.

@EmmanuelMess EmmanuelMess unpinned this issue Jan 20, 2022
@TranceLove
Copy link
Collaborator

@EmmanuelMess +1. Looks really nice.

@VishalNehra
Copy link
Member

+1

@VishalNehra
Copy link
Member

VishalNehra commented Jan 21, 2022

although this can be conflicting with #3109 don't touch the about activity layout.

@EmmanuelMess
Copy link
Member Author

@nicbn The layout is approved, but dont touch the about activity layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-UIUX Related to user interface/experience (e.g. dialogs, notifications). Bounty Issue-Easy (good first issue) Beginners welcome! Issues with relative low difficulty. Issue-Feature A feature request or improvement. Issue-Task (low) This isn't a bug, but should be dealt with.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants