Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistency of position of magnetic field #68

Open
minghuaw opened this issue Dec 13, 2021 · 1 comment
Open

Consistency of position of magnetic field #68

minghuaw opened this issue Dec 13, 2021 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@minghuaw
Copy link
Contributor

The QuadrupoleField3D and QuadrupoleField2D have their position associated with an external Position component, while PrecalculatedMagneticFieldGrid has its position defined internally. I was wondering if there is any reason for such inconsistency?

I guess this could be extended to laser beam as well because GaussianBeam also has its "position" (intersection) defined internally.
@ElliotB256
Copy link
Collaborator

You raise a good point, it would sense to make this consistent.

@ElliotB256 ElliotB256 added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 23, 2021
@tevzLotric tevzLotric mentioned this issue Mar 4, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ElliotB256 @minghuaw