Skip to content

Missing paragraph tags in remarks #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AbbyANoble opened this issue Dec 19, 2024 · 7 comments · Fixed by #514
Closed

Missing paragraph tags in remarks #512

AbbyANoble opened this issue Dec 19, 2024 · 7 comments · Fixed by #514
Assignees

Comments

@AbbyANoble
Copy link
Contributor

Finding some spots where remarks didn't include a paragraph tag. They built fine originally, but now as I'm updating things they no longer build.

@siwelwerd
Copy link
Contributor

Oof, there are a bunch of these. I'll work on fixing them all.

For posterity, here is the xpath command I'm using to track all these down:

xpath -e '//remark[not(child::p)]' source/precalculus/source/*/*.ptx

@AbbyANoble
Copy link
Contributor Author

Looks like more than just remarks! Here's one in a definition. Didn't check the source, just assuming because the preview is the same!

Definition 1.1.5
https://tbil.org/preview/precalculus/instructor/EQ1.html#EQ1-3-6

Screenshot 2024-12-19 at 1 51 02 PM

@siwelwerd
Copy link
Contributor

siwelwerd commented Dec 19, 2024

I spotted a few places where some of the text was in a <p> and some was not, which will also not show up correctly. But the script I put above won't catch that.

@AbbyANoble
Copy link
Contributor Author

I spotted a few places where some of the text was in a

and some was not, which will also not show up correctly. But the script I put above won't catch that.

image

@siwelwerd
Copy link
Contributor

Okay, this will catch any bare text (i.e. not in a child element like a <p>) in a <remark>

 xpath -e '//remark[text()[normalize-space()]][string-length() > 0]' source/precalculus/source/*/*.ptx

@siwelwerd
Copy link
Contributor

Looks like more than just remarks! Here's one in a definition. Didn't check the source, just assuming because the preview is the same!

@StevenClontz Do we know of any other elements that used to show bare text, but now require it to be in a child element? So that I can audit those as well.

@siwelwerd
Copy link
Contributor

FWIW there were only three definitions

@siwelwerd siwelwerd added this to the 2025 Early Edition milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants