[Bug]: Memory Leak of Server

[pietro-lopes]

What happened?

There is a leak of Server on Journeymap instance

Join a game, leave to main menu and server is leaked.

Mod Loader

NeoForge

Minecraft Version

1.21.x

Version

6.0.0

Relevant log output

[mysticdrew]

What is that image suppose to represent? I need a lot more details

[pietro-lopes]

This image is a heap dump, showing the Path to GC Roots when I'm at the main menu, after I joined a game and exited.
It is from Eclipse Memory Analyzer.

When we logout/exit to Main Menu some instances needs to be cleared in case you saved like Players, Levels, Server.

Here is Neoforge clearing server instance when server is closed/shutdown:
https://github.com/neoforged/NeoForge/blob/fb8915b8c3bf3220b30d35089b89dcd6a1651f30/src/main/java/net/neoforged/neoforge/server/ServerLifecycleHooks.java#L128

You should listen to ServerStoppedEvent and when it fires you clean your Journeymap instance

[mysticdrew]

There are no memory leaks, it is just maintaining the server properties which do not change per server instance. Everything else on the server is event driven and state is not maintained. JourneyMap on the server is very minimal.

[mysticdrew]

It is cleaned up now for next beta release.